Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Remove unsigned attributes #213

Open
chhzh123 opened this issue Oct 2, 2024 · 0 comments
Open

[Refactor] Remove unsigned attributes #213

chhzh123 opened this issue Oct 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@chhzh123
Copy link
Member

chhzh123 commented Oct 2, 2024

As Allo now has a strong type system with comprehensive typing rules, we may try to remove the legacy unsigned attributes in the generated MLIR code. These attributes actually increase the maintenance cost from the frontend to backend, and are not fully compatible with the native MLIR ecosystem.

The issues mentioned in cornell-zhang/hcl-dialect#7 seem to be resolved after we had the type system.
@chhzh123 chhzh123 added the enhancement New feature or request label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chhzh123