This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Throw Exception in case we have a failed entry to ensure Abortion of the Transaction (EXPOSUREAPP-2405) #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Transaction. Signed-off-by: d067928 <jakob.moeller@sap.com>
Signed-off-by: d067928 <jakob.moeller@sap.com>
jakobmoellerdev
force-pushed
the
fix/throw-exception-for-failure-in-key-retrieval
branch
from
01153fc to
46eba10
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
harambasicluka
approved these changes
Sep 9, 2020
harambasicluka
deleted the
fix/throw-exception-for-failure-in-key-retrieval
branch
jakobmoellerdev
added a commit
that referenced
this pull request
Sep 9, 2020
…the Transaction (EXPOSUREAPP-2405) (#1134) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction. Signed-off-by: d067928 <jakob.moeller@sap.com> * Adjust test to not expect call to clear cache files Signed-off-by: d067928 <jakob.moeller@sap.com>
harambasicluka
added a commit
that referenced
this pull request
Sep 17, 2020
* New Scan Confirmation Texts Change (EXPOSUREAPP-2427) (#1097) Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> * New Strings for Risikobegegnung mit niedrigem Risiko (EXPOSUREAPP-2462) (#1106) * + new strings * let the app not crash on other languages than DE * values for lint and tests * made bad test a comment * removed unnecessary strings * more string fixes Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Luka Harambasic <luka.harambasic@sap.com> * Remove Cache Clearing to reduce CDN load on failing devices (EXPOSUREAPP-2405) (#1108) * Remove Cache Clearing to reduce CDN load on failing devices. This ideally needs to be accompanied by a way to clear the cache manually and a way to identify more root causes of Transaction Failures. Signed-off-by: d067928 <jakob.moeller@sap.com> * Remove Files that failed for Key Retrieval Only Remove Files from Cache that failed to download, instead of every file. This is accompanied ideally by no rollback in the Key Retrieval. We only delete the cache ref, the file will not be deleted as it is considered not present Signed-off-by: d067928 <jakob.moeller@sap.com> * Introduce dedicated QuotaCalculator for Unit Testing Signed-off-by: d067928 <jakob.moeller@sap.com> * Refactor QuotaCalculator for LocalData Property Access and Write Tests Signed-off-by: d067928 <jakob.moeller@sap.com> * Use Instant on the Device Read since this is not timezone specific Signed-off-by: d067928 <jakob.moeller@sap.com> * Add specific state for the quota calculation and dedicated rollback Signed-off-by: d067928 <jakob.moeller@sap.com> * PR Comments Signed-off-by: d067928 <jakob.moeller@sap.com> * Feature: Update low risk string (EXPOSUREAPP-1971) (#1125) * Improve Explanation for "Risikobegegnung mit niedrigem Risiko" (EXPOSUREAPP-1971) (#1112) * Adapt QuotaCalculatorTest to old JUnit4 API Signed-off-by: d067928 <jakob.moeller@sap.com> * [INTERNAL] Translation delivery: commit by LX Lab (#1132) Change-Id: Ib76a9ea2b03163a05dd8b6acf2179262f9bcf5bf * Removed ar & ru and updated defaults (#1133) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction (EXPOSUREAPP-2405) (#1134) * Throw Exception in case we have a failed entry to ensure Abortion of the Transaction. Signed-off-by: d067928 <jakob.moeller@sap.com> * Adjust test to not expect call to clear cache files Signed-off-by: d067928 <jakob.moeller@sap.com> * version bump to 1.3.1 * Reverted replaced wording (EXPOSUREAPP-2638) (#1153) * Fix: No exposure with low risk so far * Fixed klint issues (#1144) * restored reverted replaced wording for lint * #1153 (comment) * fixed term * Align TestFragment Crash behavior with background transaction crash behavior. * Add logging mechanism to debug hotfix issue. * Lint Resolvement, Nav Graph Issue clean, Enable Log for deviceForTesters, Correct Quota Tests due to now lacking exception Signed-off-by: d067928 <jakob.moeller@sap.com> Co-authored-by: Philipp Woessner <64482866+pwoessner@users.noreply.github.com> Co-authored-by: Jakob Möller <jakob.moeller@sap.com> Co-authored-by: Rituraj Sambherao <54317407+ritsam@users.noreply.github.com> Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by: chris-cwa <69595386+chris-cwa@users.noreply.github.com> Co-authored-by: Luka Harambasic <luka.harambasic@sap.com> Co-authored-by: SAP LX Lab Service Account <tmsatsls+github.com_service-tip-git@sap.com> Co-authored-by: Matthias Urhahn <matthias.urhahn@sap.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: d067928 jakob.moeller@sap.com
This is done to ensure we do not submit files with remaining files after a failure is cleared in the Download Cache. Testable by provoking a download failure and not seeing exposure checks anymore as well as an IOException wrapped by a Transaction Exception if done in foreground