Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

code smell fixes (EXPOSURAPP-3058) #1330

Merged
merged 14 commits into from
Oct 7, 2020
Merged

code smell fixes (EXPOSURAPP-3058) #1330

merged 14 commits into from
Oct 7, 2020

Conversation

AndroidMedaGalaxy
Copy link
Member

@AndroidMedaGalaxy AndroidMedaGalaxy commented Oct 6, 2020 •
edited
Loading

Description

Code smell fixes
image

@AndroidMedaGalaxy AndroidMedaGalaxy requested a review from a team October 6, 2020 11:48
@AndroidMedaGalaxy AndroidMedaGalaxy marked this pull request as draft October 6, 2020 11:49
@ralfgehrer ralfgehrer added this to the 1.5.0 milestone Oct 6, 2020
@ralfgehrer ralfgehrer added the maintainers Tag pull requests created by maintainers label Oct 6, 2020
@AndroidMedaGalaxy AndroidMedaGalaxy marked this pull request as ready for review October 6, 2020 15:41
ralfgehrer
ralfgehrer previously approved these changes Oct 6, 2020
View reviewed changes
d4rken
d4rken suggested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One codestyle thing, otherwise lgtm.

Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/GoogleAPIVersion.kt Outdated Show resolved Hide resolved
d4rken
d4rken approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for CircleCI to give it's blessing.

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

31.4% 31.4% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit 1948fd8 into release/1.5.x Oct 7, 2020
@d4rken d4rken deleted the fix/code-smells-(EXPOSUREAPP-3058) branch October 7, 2020 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@ralfgehrer ralfgehrer ralfgehrer left review comments

Assignees
No one assigned
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AndroidMedaGalaxy @ralfgehrer @d4rken