This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Cannot delete tests older than 21 days - DE: Tests die älter als 21 Tage sind, können nicht gelöscht werden (EXPOSUREAPP-2398) #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tworkRequestWrapper that is able to represent multiple states. This allows for better request state handling throughout the app 2. Completely removed the SubmissionViewModel 3. Failure to fetch the test should now always display the invalid test card on the home screen Signed-off-by: Kolya Opahle <k.opahle@sap.com>
…ot indicate any problems with the test itself Signed-off-by: Kolya Opahle <k.opahle@sap.com>
…ew card) Signed-off-by: Kolya Opahle <k.opahle@sap.com>
kolyaopahle
added
backend
chris-cwa
approved these changes
Nov 13, 2020
|
Tested it together with #1600, worked as expected. |
|
code lgtm. running device tests with different fetches.. will come back later |
|
Kudos, SonarCloud Quality Gate passed!
|
BMItr
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Code looks good to me. Local Tests passed.
Tested various conditions on emulated QRs on WRU-XD
Default Test: local tests passed,
pending QR: passed
invalid QR: passed
negativ QR: passed
positiv QR: passed
UI updates accordingly.
Note: I will contact you on one smaller issue.
Approved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original pr #1481 did not fix the actual issue people were having in production.
This PR implements a refactoring of the whole state handling process for test result fetching and should hopefully get rid of the actual underlying issue.
Please make sure to test the risk status fetching behaviour thouroughly, especially on the homescreen. Using the cwa server emulator should help in the process. Also check behaviour with varying network connectivity states
Steps to reproduce
With Emulator:
To test the specific 21 days failure case you need to do the following:
Without emulator