This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Improve HotDataFlow behavior (EXPOSUREAPP-3777) #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
d4rken
commented
Nov 16, 2020
d4rken
commented
- Prevent re-execution of past submissions when the observable goes cold.
- Guard internal value updates with a mutex in case the value update is not as thread-safe as we think it is.
* Prevent re-execution of past submissions when the observable goes cold. * Guard internal value updates with a mutex in case the value update is not as thread-safe as we think it is.
d4rken
added
bug
d4rken
commented
Nov 16, 2020
| Timber.tag(tag).v("updateActions resetReplayCache().") | ||
| updateActions.resetReplayCache() | ||
| } | ||
| .collect { updateAction -> |
There was a problem hiding this comment.
I'm suspicious that our access of currentValue in .collect { } was not thread-safe, which is why I added the mutex.
d4rken
commented
Nov 16, 2020
| updateActions | ||
| .onCompletion { | ||
| Timber.tag(tag).v("updateActions resetReplayCache().") | ||
| updateActions.resetReplayCache() |
There was a problem hiding this comment.
When we unsubscribe, and the HotDataFlow goes cold, and then resubscribe, we would replay all previous update actions on the new value.
I don't think this affected the current issue, but it's a bug nonetheless. We should reset the cache here to prevent the actions from being replayed.
ralfgehrer
previously approved these changes
Nov 16, 2020
chiljamgossow
previously approved these changes
Nov 16, 2020
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/util/flow/HotDataFlowTest.kt
Outdated
Show resolved
Hide resolved
d4rken
dismissed stale reviews from chiljamgossow and ralfgehrer
via
66de9d1
|
Kudos, SonarCloud Quality Gate passed!
|
BMItr
approved these changes
Nov 16, 2020
ralfgehrer
approved these changes
Nov 16, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.