Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Release version 1.6.1 #1620

Merged
merged 5 commits into from
Nov 16, 2020
Merged

Release version 1.6.1 #1620

merged 5 commits into from
Nov 16, 2020

Conversation

kaddaSz
Copy link
Contributor

@kaddaSz kaddaSz commented Nov 16, 2020

Release Version 1.6.1

d4rken and others added 3 commits November 16, 2020 12:09
#1604)

* Flush the json data after writing it, otherwise if the app process dies, we end up with an empty file.
GSON deserializes this into a null object that looks like a non-null object until it is evaluated some time later.

Force an evaluation via `require(it.size >= 0)` and delete the corrupt data file when catching the exception.

* Show a visible error dialog if we fail to save data.

* Used buffered versions of readers and writer.
* Fix HotDataFlow behavior.
* Prevent re-execution of past submissions when the observable goes cold.
* Guard internal value updates with a mutex in case the value update is not as thread-safe as we think it is.

* Fix problematic testcases.
Co-authored-by: Ralf Gehrer <ralfgehrer@users.noreply.github.com>
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Nov 16, 2020
harambasicluka
harambasicluka previously approved these changes Nov 16, 2020
@harambasicluka harambasicluka self-assigned this Nov 16, 2020
d4rken
d4rken previously approved these changes Nov 16, 2020
@harambasicluka harambasicluka dismissed stale reviews from d4rken and themself via 2c19cc9 November 16, 2020 18:21
@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

72.0% 72.0% Coverage
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants