Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

PPA onboarding screen (EXPOSUREAPP-4815) #2299

Merged
merged 24 commits into from
Feb 10, 2021
Merged

PPA onboarding screen (EXPOSUREAPP-4815) #2299

merged 24 commits into from
Feb 10, 2021

Conversation

AlexanderAlferov
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov commented Feb 5, 2021 •
edited
Loading

Onboarding screen for PPA.

Vuzix View_20210205_174918_174

How to test:

  1. Fresh install/Reset app
  2. Check the last onboarding screen
  3. Turn on Screen reader accessibility feature and play around the screen

@AlexanderAlferov AlexanderAlferov added maintainers Tag pull requests created by maintainers do not merge text change PRs with text changes. labels Feb 5, 2021
@AlexanderAlferov AlexanderAlferov added this to the 1.13.0 milestone Feb 5, 2021
@harambasicluka harambasicluka added prio PRs to review first. enhancement Improvement of an existing feature labels Feb 9, 2021
@mtwalli
Copy link
Contributor

mtwalli commented Feb 9, 2021 •
edited
Loading

Scroll state is not kept, User has to scroll again to where he was

device-2021-02-09-123134.mp4

mtwalli
mtwalli reviewed Feb 9, 2021
View reviewed changes
...na-Warn-App/src/main/java/de/rki/coronawarnapp/ui/onboarding/OnboardingAnalyticsViewModel.kt
fun onDisableClick() {
settings.userInfoAgeGroup.update { PpaData.PPAAgeGroup.AGE_GROUP_UNSPECIFIED }
settings.userInfoFederalState.update { PpaData.PPAFederalState.FEDERAL_STATE_UNSPECIFIED }
settings.userInfoDistrict.update { 0 }
Copy link
Contributor

@mtwalli mtwalli Feb 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a constant in District -> District.UNSPECIFIED_DIRSTRICT
and use it here instead of 0

@mtwalli mtwalli self-assigned this Feb 9, 2021
harambasicluka
harambasicluka reviewed Feb 9, 2021
View reviewed changes
Corona-Warn-App/src/main/res/values-de/legal_strings.xml Outdated
@@ -49,4 +49,17 @@
<string name="contact_diary_onboarding_privacy_information_second_section_body_one">Bitte prüfen Sie genau, mit wem und auf welche Weise Sie die in Ihrem Kontakt-Tagebuch erfassten Informationen teilen. Die Informationen sollen Ihnen als Gedächtnisstütze dienen - sie sind nicht für Dritte bestimmt. Wenn das Gesundheitsamt Sie im Rahmen der Kontaktnachverfolgung um Ihre Mithilfe bittet, ist die Weitergabe von Einträgen sachgerecht.</string>
<!-- XTXT: Body for the contact diary onboarding privacy information second section -->
<string name="contact_diary_onboarding_privacy_information_second_section_body_two">Private Personen oder Unternehmen dürfen von Ihnen nicht die Weitergabe der von Ihnen erfassten Informationen verlangen. Bitte respektieren Sie, wenn jemand nicht im Kontakt-Tagebuch erfasst werden möchte.</string>

<!-- XTXT: Body for Privacy-preserving Analytics -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @janetback please also add the legal headlines here.

AlexanderAlferov and others added 2 commits February 9, 2021 15:51
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/1.13.x' into feature/481…
da7129e 
…5-ppa-onboarding

# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/menu/ui/TestMenuFragmentViewModel.kt
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/ui/main/MainActivityTestModule.kt
#	Corona-Warn-App/src/deviceForTesters/res/navigation/test_nav_graph.xml
#	Corona-Warn-App/src/main/res/values-de/strings.xml
#	Corona-Warn-App/src/main/res/values/strings.xml
@janetback @ralfgehrer
Missing sentence in description of contact journal (EXPOSUREAPP-4941) #…
ebded2f 
…2309

Co-authored-by: Ralf Gehrer <ralfgehrer@users.noreply.github.com>
@ralfgehrer ralfgehrer mentioned this pull request Feb 9, 2021
Closed
janetback and others added 10 commits February 9, 2021 14:12
@janetback @ralfgehrer
Change statistics overview header to 'bundesweite' Statistiken (EXPOS…
c306f7a 
…UREAPP-4975) #2305

Co-authored-by: Ralf Gehrer <ralfgehrer@users.noreply.github.com>
@chiljamgossow @ralfgehrer
Show normal behavior box when tracing disabled (EXPOSUREAPP-4768) #2306
c8fd5a1 
use toolbar

Co-authored-by: Ralf Gehrer <ralfgehrer@users.noreply.github.com>
@AlexanderAlferov
Merge remote-tracking branch 'origin/release/1.13.x' into feature/481…
5b3cd15 
…5-ppa-onboarding
@AlexanderAlferov
Delta onboarding analytics screen
f051997
@AlexanderAlferov
Delta onboarding navigation
e6f0520
@AlexanderAlferov
Strings fix
dd6bbb5
@AlexanderAlferov
Comment for Kolya
adc3d3e
@AlexanderAlferov
Layout, nav grav and fragments refactoring
f4893fd
@AlexanderAlferov
Merge remote-tracking branch 'origin/feature/4321-ppa-main' into feat…
169431f 
…ure/4815-ppa-onboarding

# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/res/navigation/test_nav_graph.xml
#	Corona-Warn-App/src/main/res/values-de/strings.xml
#	Corona-Warn-App/src/main/res/values/strings.xml
@AlexanderAlferov
Merge conflicts and formatting
104db50
@AlexanderAlferov AlexanderAlferov marked this pull request as ready for review February 9, 2021 18:36
@AlexanderAlferov AlexanderAlferov requested review from a team February 9, 2021 18:36
kolyaopahle
kolyaopahle approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing stuff looks good to me, is there any kind of delta onboarding when a user is not starting the app initially?

@AlexanderAlferov
Copy link
Contributor Author

Existing stuff looks good to me, is there any kind of delta onboarding when a user is not starting the app initially?

Yes, delta onboarding is also in place. Screen should appear right after "whats new screen".

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

4.6% 4.6% Coverage
13.3% 13.3% Duplication

mtwalli
mtwalli approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tested on Samsung S8. Both cases in fresh onboarding and delta onboarding.

@kolyaopahle kolyaopahle merged commit d3c3537 into feature/4321-ppa-main Feb 10, 2021
@kolyaopahle kolyaopahle deleted the feature/4815-ppa-onboarding branch February 10, 2021 12:02
@axelherbstreith axelherbstreith mentioned this pull request Feb 10, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harambasicluka harambasicluka harambasicluka left review comments

@kolyaopahle kolyaopahle kolyaopahle approved these changes

@mtwalli mtwalli mtwalli approved these changes

@axelherbstreith axelherbstreith Awaiting requested review from axelherbstreith

Assignees

@mtwalli mtwalli

@kolyaopahle kolyaopahle

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexanderAlferov @mtwalli @harambasicluka @kolyaopahle @janetback @chiljamgossow