Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adapt 'fake correct device time' feature (DEV) #2320

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Adapt 'fake correct device time' feature (DEV) #2320

merged 5 commits into from
Feb 10, 2021

Conversation

LukasLechnerDev
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev commented Feb 10, 2021 •
edited
Loading

This adjusts and extends the test menu feature from @d4rken => #2316

  • Change the hardcoded offset from 90 to 0
  • Add a description of the "Fake correct device time" in the Test Menu

image

@LukasLechnerDev LukasLechnerDev requested review from a team, ralfgehrer and d4rken February 10, 2021 16:40
@d4rken d4rken self-assigned this Feb 10, 2021
d4rken
d4rken approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ralfgehrer ralfgehrer self-assigned this Feb 10, 2021
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Feb 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 3dfd4d8 into release/1.13.x Feb 10, 2021
@harambasicluka harambasicluka deleted the fix/DEV-Adapt-fake-correct-device-time-TestMenu branch February 10, 2021 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@ralfgehrer ralfgehrer ralfgehrer approved these changes

Assignees

@ralfgehrer ralfgehrer

@d4rken d4rken

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukasLechnerDev @ralfgehrer @d4rken @harambasicluka