New consent Google API (EXPOSUREAPP-4635)

[mtwalli]

Google play services version that is required by this PR: 18210214000

• Trigger Google consent Dialog when needed to share keys
• Fallback if unrecoverable error happened is to use older Api for getting the keys
• Old consent boolean flag in the App is not affected by this change regardless of user selection 😒
• Ticket is addressing the consent only before scanning QR-Code, while I show when it is (needed and possible) in other places such as warn others.
• In case of disallowance, this can be revoked from Google settings -> switch on/off

Note:

requestPreAuthorizedTemporaryExposureKeyHistory and requestPreAuthorizedTemporaryExposureKeyRelease
are used always in combination. i.e:
1- requestPreAuthorizedTemporaryExposureKeyRelease can not succeed unless requestPreAuthorizedTemporaryExposureKeyHistory is called before.
2- requestPreAuthorizedTemporaryExposureKeyHistory is triggering the consent dialog once as long as requestPreAuthorizedTemporaryExposureKeyRelease was not called at least once in the next 5 days.

Testing: test the submission flow as before. This change require Google play services Update. Old versions should still work and use older Apis

Important notes:

1- Resetting the App -> does not revoke the consent
2- Consent is completely independent from Test results (positive - pending - negative) -> therefore if you saw it once that is OK (you will be asked when ever this possible)

TAN scenarios:

1- if you were about to use QR code scan and you saw the consent dialog and took an action that is enough for any other case that requires consent such as TAN -> we can only show the consent once using the new Api
2- if you have not seen the consent before ,you should see it when following TAN process , later after you enter it and proceed to warn others

Some scenarios:

Case 1: Happy path user allows the consent and proceed to sharing the keys.
https://user-images.githubusercontent.com/25054729/107620898-b8993380-6c55-11eb-9447-b1927f3796a1.mp4

Case 2: User dis-allow form the consent ,we proceed anyway to the keys sharing using the old api
https://user-images.githubusercontent.com/25054729/107625156-32342000-6c5c-11eb-88e6-e0dba01f40db.mp4

[harambasicluka]

Did some on device testing, everything worked as expected:

Xiaomi Mi 9: Android 9; ENF 18210214000

• Happy path:
  https://user-images.githubusercontent.com/64483219/107773678-4a7c6b80-6d3e-11eb-9ef8-e7bf20df15c9.mp4

• Canceled consent, came back:
  https://user-images.githubusercontent.com/64483219/107773714-59631e00-6d3e-11eb-8871-aa7414f44ac2.mp4

• Consent still valid after reactivating the in EOL:
  https://user-images.githubusercontent.com/64483219/107773758-6849d080-6d3e-11eb-9184-5e313f24ad25.mp4

• If the new consent is denied the old one shows up:
  https://user-images.githubusercontent.com/64483219/107773800-77308300-6d3e-11eb-9c73-a489ac20f7d7.mp4

Pixel 3: Android 11; ENF 18205016000

• Old ENF version didn't try to use the new consent dialog, the old one is still there:

pixel3_old_enf_version.mp4

[ralfgehrer]

On a Pixel (Android 10) with Play service 18210214000
I tested all edge cases with QR codes. Even scanning a positive code, resetting the app, scanning a positive test, ... worked as expected.

Afterward, I used the Tele Tan, reset the app, and was about to use the QR Code: before scanning the code, I was not prompted to share keys BEFORE scanning the code - as I would have expected. Is this a bug or a wrong assumption of mine?

[mtwalli]

@ralfgehrer , Thanks, could you please record a video of the scenario that you think it is problematic? then I can investigate it properly

[ralfgehrer]

@ralfgehrer , Thanks, could you please record a video of the scenario that you think it is problematic? then I can investigate it properly

I tried to reproduce the bug again and record a video, but was not able to. Maybe I did not pay super close attention earlier in the last run. But on the bright side, all seems to work very nicely. Ran about 10 more tests ;)

[ralfgehrer]

Thanks for the extra set of tests!

[jurajkusnier]

LGTM

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

73.1% Coverage
0.0% Duplication

[mar-v-in]

According to the first message in the PR, this feature requires Google play services version 18,210,214,000
The latest Google play services version according to apkmirror.com is 210,214,000 released in Februar 2021.

So I guess you're not referring to Google play services version but something else?

[mtwalli]

According to the first message in the PR, this feature requires Google play services version 18,210,214,000
The latest Google play services version according to apkmirror.com is 210,214,000 released in Februar 2021.

So I guess you're not referring to Google play services version but something else?

To be precise : Exposure Notifications Version, You can check that by going to:
Device Settings -> Google Settings -> COVID-19 Exposure Notifications -> Scroll to the bottom