This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Missing tracing duration on low risk detail screen (EXPOSUREAPP-5092) #2326
Merged
ralfgehrer
merged 5 commits into
release/1.13.x
from
fix/5092-Missing-tracing-duration-on-low-risk-detail-screen
Feb 12, 2021
Merged
Missing tracing duration on low risk detail screen (EXPOSUREAPP-5092) #2326
ralfgehrer
merged 5 commits into
release/1.13.x
from
fix/5092-Missing-tracing-duration-on-low-risk-detail-screen
Feb 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harambasicluka
previously approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a Pixel3, works as expected! Thanks :)
…on-low-risk-detail-screen
ralfgehrer
reviewed
Feb 11, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/ui/ViewExtensions.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Feb 11, 2021
Corona-Warn-App/src/main/res/layout/tracing_content_low_view.xml
Outdated
Show resolved
Hide resolved
…n-on-low-risk-detail-screen' into fix/5092-Missing-tracing-duration-on-low-risk-detail-screen
harambasicluka
approved these changes
Feb 12, 2021
…on-low-risk-detail-screen
Kudos, SonarCloud Quality Gate passed! |
ralfgehrer
approved these changes
Feb 12, 2021
ralfgehrer
deleted the
fix/5092-Missing-tracing-duration-on-low-risk-detail-screen
branch
February 12, 2021 10:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The active tracing history ("Exposure logging was active for x of the past 14 days.) was missing in the low-risk detail screen. It was only missing when there were encounters.
Fix: I made it visible on the detail screen via editing the binding expression in the layout. I created a new binding adapter to simplify the expression.
To get a low-risk card with encounters do: Test Menu => Select LOW_RISK_DEFAULT => press "Calculate Risk Level".
Before:
After: