This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Filter emojis in RAT profile fields (EXPOSUREAPP-8108) #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
added
bug
| ): CharSequence? { | ||
| for (index in start until end) { | ||
| val type = Character.getType(source[index]).toByte() | ||
| if (type in listOf(SURROGATE, OTHER_SYMBOL)) return "" |
There was a problem hiding this comment.
Could you please add some tests to it so that we can sure that it doesn't interfere with other alphabets, e.g. russian with cyrillic letters (@AlexanderAlferov may provide you some test data), danish with Ø.
3 tasks
jurajkusnier
approved these changes
Jul 2, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎥
device-2021-07-01-142812.mp4
Testing
1- Create a new RAT profile
2- Try to enter emojis
3- Enter name or address in DE, EN, TR , ... it should be as before