Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Test profile input validation (EXPOSUREAPP-8524) #3771

Merged
merged 13 commits into from
Jul 23, 2021
Merged

Test profile input validation (EXPOSUREAPP-8524) #3771

merged 13 commits into from
Jul 23, 2021

Conversation

marcauberer
Copy link
Member

@marcauberer marcauberer commented Jul 21, 2021

Adds validation / input constraints to the fields phone number, email, date of birth and postal code

  • Phone number gets validated with the PHONE validator pattern (valid phone number required to save profile)
  • Email gets validated with the EMAIL_ADDRESS validator pattern (valid email address required to save profile)
  • Postal code gets limited to 5 chars as we do not have longer postal codes in Germany
  • Date of birth now rejects data selections in the future

Furthermore, this pr adds formatting of the phone number text field for more intuitivity.

We had a discussion about input validation at the QM department last week and the status quo was, that input validation is not planned to implement from SAP side. I thought to make an open source contribution, to provide a solution in case the interest exists ...


Internal Tracking ID: EXPOSUREAPP-8524

@marcauberer marcauberer requested a review from a team July 21, 2021 11:55
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Jul 21, 2021
@harambasicluka harambasicluka added this to the 2.7.0 milestone Jul 21, 2021
d4rken
d4rken previously approved these changes Jul 22, 2021
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtwalli mtwalli self-assigned this Jul 22, 2021
@marcauberer marcauberer requested a review from a team July 22, 2021 13:24
Copy link
Contributor

@NataliaLemmerth NataliaLemmerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved.

@marcauberer marcauberer requested review from mtwalli and d4rken July 22, 2021 13:46
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BMItr BMItr self-assigned this Jul 23, 2021
@harambasicluka harambasicluka merged commit 15ebb23 into corona-warn-app:release/2.7.x Jul 23, 2021
@marcauberer marcauberer deleted the feature/test-profile-input-validation-2.7 branch July 23, 2021 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants