This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Test profile input validation (EXPOSUREAPP-8524) #3771
Merged
harambasicluka
merged 13 commits into
corona-warn-app:release/2.7.x
from
marcauberer:feature/test-profile-input-validation-2.7
Jul 23, 2021
Merged
Test profile input validation (EXPOSUREAPP-8524) #3771
harambasicluka
merged 13 commits into
corona-warn-app:release/2.7.x
from
marcauberer:feature/test-profile-input-validation-2.7
Jul 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
d4rken
previously approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mtwalli
reviewed
Jul 22, 2021
.../main/java/de/rki/coronawarnapp/ui/coronatest/rat/profile/create/RATProfileCreateFragment.kt
Outdated
Show resolved
Hide resolved
.../main/java/de/rki/coronawarnapp/ui/coronatest/rat/profile/create/RATProfileCreateFragment.kt
Outdated
Show resolved
Hide resolved
NataliaLemmerth
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA approved.
mtwalli
approved these changes
Jul 23, 2021
BMItr
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation / input constraints to the fields
phone number
,email
,date of birth
andpostal code
PHONE
validator pattern (valid phone number required to save profile)EMAIL_ADDRESS
validator pattern (valid email address required to save profile)Furthermore, this pr adds formatting of the phone number text field for more intuitivity.
We had a discussion about input validation at the QM department last week and the status quo was, that input validation is not planned to implement from SAP side. I thought to make an open source contribution, to provide a solution in case the interest exists ...
Internal Tracking ID: EXPOSUREAPP-8524