This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Clear the key packages and app config on ENError = 2 #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcussc
approved these changes
Oct 16, 2020
| @@ -109,11 +109,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| // use a custom http client that uses/recognized caching mechanisms | |||
| let appFetchingClient = CachingHTTPClient(clientConfiguration: client.configuration) | |||
|
|
|||
| // we currently use the store as common place for temporal persistency | |||
| guard let store = store as? AppConfigCaching else { | |||
src/xcode/ENA/ENA/Source/Services/Exposure Transaction/ExposureDetectionExecutor.swift
Show resolved
Hide resolved
KaiTeuber
approved these changes
Oct 16, 2020
|
|
||
| // Clear the key packages and app config on ENError = 2 = .badParameter | ||
| // For more details, see: https://jira.itc.sap.com/browse/EXPOSUREAPP-3297 | ||
| func clearCacheOnError2(error: Error) { |
There was a problem hiding this comment.
why call this func ..OnError2 and explain the error code in the comment?
I think we should use a better name here, like
clearCacheOnErrorBadParameter
marcussc
deleted the
fix/3297-Reset_Diagnosis_Key_Cache_on_EN_Error_Code_2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resets the key packages and app config when ENError = 2 (badParameter) occurs.
Link to Jira
3297