This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Exposure Submission Flow - Error Alert adjustments #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd german and english language keys
melloskitten
requested review from
a team,
thomasaugsten,
johannesrohwer,
steins-code,
ChristianKienle,
eisvogel and
inf2381
melloskitten
changed the title
inf2381
changed the title
MichaelPFrey
reviewed
Jul 3, 2020
| @@ -53,18 +53,26 @@ class ExposureSubmissionWarnOthersViewController: DynamicTableViewController, EN | |||
| exposureSubmissionService = exposureSubmissionService ?? (navigationController as? ExposureSubmissionNavigationController)?.exposureSubmissionService | |||
| } | |||
|
|
|||
| // MARK: - ExposureSubmissionService Helpers. | |||
There was a problem hiding this comment.
Ah, thanks for the comment. Accident on my side 👍
steins-code
reviewed
Jul 6, 2020
| /// - secondaryActionCompletion: The completion handler for the secondary action. | ||
| /// - Returns: An alert with either one or two actions, with the specified completion handlers | ||
| /// and texts. | ||
| static func setupErrorAlert( |
There was a problem hiding this comment.
Do we really need this additional file? Or can we consolidate it and use only extension of UIViewController + Alert.swift and maybe extend this one
There was a problem hiding this comment.
Good point. I have refactored it into the already existing extension 👍
johannesrohwer
approved these changes
Jul 6, 2020
| message: String, | ||
| okTitle: String? = nil, | ||
| secondaryActionTitle: String? = nil, | ||
| hasSecondaryAction: Bool = false, completion: (() -> Void)? = nil, |
There was a problem hiding this comment.
done, thanks for the notice.
steins-code
approved these changes
Jul 6, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to implement a better error handling of the infamous EN errors, as described in this issue here. Please note that this handles the errors thrown in the Exposure Submission flow primarily.
It will handle the ENError 5, 11, and 13. All of them now have an Alert Action "Mehr erfahren" that leads you to the FAQ.
I have also refactored the Error handling for the Exposure Submission flow, which had a lot of unecessary methods that did exactly the same thing. I also adjusted some namings because they seemed confusing to me (e.g. retry -> secondaryAction for alerts, and so on.)