Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Deactivate emojis, etc. for Rapid Test Profile #605

Closed
2 of 3 tasks
Ein-Tim opened this issue May 7, 2021 · 22 comments
Closed
2 of 3 tasks

Deactivate emojis, etc. for Rapid Test Profile #605

Ein-Tim opened this issue May 7, 2021 · 22 comments
Assignees
Labels
bug Something isn't working Fix 2.5 Fix is planned for 2.5 mirrored-to-jira This item is also tracked internally in JIRA rapid-test

Comments

@Ein-Tim
Copy link
Contributor

Ein-Tim commented May 7, 2021

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
  • Bug is not already reported in another issue

Technical details

  • Device name: iPhone 12 Emulator
  • iOS version: 14.5
  • App version: 2.2.0 (9)

Describe the bug

You can enter emojis into the following fields:

  • "First Name"
  • "Last Name"
  • "Street and House Number"
  • "City"
  • "E-Mail Adress"

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Click on "Next Steps"
  3. Click on "Create Rapid Test Profile"
  4. Enter Emojis or other special letters (§, %, etc.) into the fields mentioned above

Expected behaviour

You can only enter "normal" characters into the fields.

Possible Fix

Validate the input.

Additional context

I think that this is a priority issue since the Luca app got recently "shitstormed" for the option to enter any characters into the address field during their register process, so to prevent bad PR for this new feature I suggest to fix this ASAP.


Internal Tracking ID: EXPOSUREAPP-7147 iOS
Internal Tracking ID: EXPOSUREAPP-8108 Android

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented May 7, 2021

Could someone check this under Android? (@fynngodau, @MikeMcC399)

@fynngodau
Copy link

@Ein-Tim It is possible to enter emojis with Android.

However, since this is data that is being shown only to the testing center, where they will manually have a look at it, it doesn't seem as important to me. In specific, your name needs to match the name on your passport.

Screenshot_1620423042

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented May 7, 2021

@fynngodau Thanks!

I understand that this has a different scope than f.e. the Luca thing, still it could make bad PR and this could be avoided by just adding a validation to the input fields.

However, I'll remove the "PRIO?" from the title, since it should be enough to deliver this fix in a later version.

@Ein-Tim Ein-Tim changed the title [PRIO?] Deactivate emojis, etc. for Rapid Test Profile Deactivate emojis, etc. for Rapid Test Profile May 7, 2021
@dsarkar dsarkar transferred this issue from corona-warn-app/cwa-app-ios May 9, 2021
@dsarkar dsarkar added bug Something isn't working mirrored-to-jira This item is also tracked internally in JIRA rapid-test labels May 9, 2021
@dsarkar
Copy link
Member

dsarkar commented May 9, 2021

@fynngodau @Ein-Tim Thanks. Internal Tracking ID: EXPOSUREAPP-7147


Corona-Warn-App Open Source Team

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented May 11, 2021

In fact, I can see, that there is no input validation at all (like birthday can only be numbers, e-mail address has to include a @, etc.)

@ndegendogo
Copy link

I agree that emojis are not expected to be used in names field. However, the set of valid characters should not be limited to pure ASCII letters. In Germany, we have Umlauts. Many people have accents in their names. And people from other cultures can have most of the Unicode letters. If you don't want to exclude / discriminate these people, it will be not easy to specify the "allowed" or "forbidden" letters.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented May 14, 2021

@ndegendogo

I agree with you there, but let's also agree to:

  • Deactivate emojis
  • Force the date of birth to be all numbers (via the emulator I can enter letters...)
  • Force the date of birth to be in the past

Or do you think there could be any problems with this?

@jucktnich
Copy link

@Ein-Tim you can also just paste letters into birth date

@DerVogel2020
Copy link

DerVogel2020 commented May 14, 2021

In the android app, I cannot paste letters, since the format dd.mm.yy is not satisfied.
But a date in the future is possible to select.
PLZ can be a text.

@jucktnich
Copy link

Oh sorry, there's an input validation there for birthday, you can paste it, but it stays nil if you save the profile

@ndegendogo
Copy link

@Ein-Tim sure 😅

@dsarkar dsarkar added the Fix 2.5 Fix is planned for 2.5 label Jun 28, 2021
@dsarkar
Copy link
Member

dsarkar commented Jun 28, 2021

Internal Tracking ID: EXPOSUREAPP-7147 iOS
Internal Tracking ID: EXPOSUREAPP-8108 Android

@dsarkar
Copy link
Member

dsarkar commented Jun 28, 2021

FYI PR iOS corona-warn-app/cwa-app-ios#3018

@dsarkar
Copy link
Member

dsarkar commented Jul 1, 2021

FYI PR Android corona-warn-app/cwa-app-android#3597

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jul 14, 2021

I can confirm that this has been fixed with version 2.5 on iOS 14.6.
The only flaw I see is that you can paste non-number characters into the "Telefonnummer" field, but I think this is negligible here.

Can someone under Android confirm the fix?

@ndegendogo
Copy link

@Ein-Tim well ... non-number characters can be valid in a phone number ... think of the '+' at the beginning of an international number ... and the number block on my phone has also buttons for '#' and '*'

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jul 15, 2021

@ndegendogo

You're absolutely right, but I can paste letters in there... I don't know phone numbers with letter 😉
I should have been clearer with which non-number characters I mean, sorry.

@dsarkar
Copy link
Member

dsarkar commented Jul 15, 2021

@ndegendogo @Ein-Tim I confirm, that on Android/Galaxy A21s emojis cannot be introduced in the RAT profile.

Regarding the phone numbers: I can only use some specific characters apart from numbers, but I do not get the keyboard for the letters. This might be a specific function of this phone.

Anyway, I suggest closing this issue regarding emojis as fixed.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jul 15, 2021

Yes, I also consider this as fixed. The other issue with the letters in the phone number is negligible here.

Thank you @dsarkar for confirming the fix under Android.

Closing as fixed.

@Ein-Tim Ein-Tim closed this as completed Jul 15, 2021
@dsarkar
Copy link
Member

dsarkar commented Jul 15, 2021

Thanks everybody.

@Ein-Tim
Copy link
Contributor Author

Ein-Tim commented Jul 20, 2021

FYI: corona-warn-app/cwa-app-android#3764 from a community contributor will improve the input validation under Android even more.

@marcauberer
Copy link
Member

FYI: corona-warn-app/cwa-app-android#3764 from a community contributor will improve the input validation under Android even more.

New pr: corona-warn-app/cwa-app-android#3771

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Fix 2.5 Fix is planned for 2.5 mirrored-to-jira This item is also tracked internally in JIRA rapid-test
Projects
None yet
Development

No branches or pull requests

8 participants