-
Notifications
You must be signed in to change notification settings - Fork 344
Deactivate emojis, etc. for Rapid Test Profile #605
Comments
Could someone check this under Android? (@fynngodau, @MikeMcC399) |
@Ein-Tim It is possible to enter emojis with Android. However, since this is data that is being shown only to the testing center, where they will manually have a look at it, it doesn't seem as important to me. In specific, your name needs to match the name on your passport. |
@fynngodau Thanks! I understand that this has a different scope than f.e. the Luca thing, still it could make bad PR and this could be avoided by just adding a validation to the input fields. However, I'll remove the "PRIO?" from the title, since it should be enough to deliver this fix in a later version. |
@fynngodau @Ein-Tim Thanks. Internal Tracking ID: EXPOSUREAPP-7147 Corona-Warn-App Open Source Team |
In fact, I can see, that there is no input validation at all (like birthday can only be numbers, e-mail address has to include a @, etc.) |
I agree that emojis are not expected to be used in names field. However, the set of valid characters should not be limited to pure ASCII letters. In Germany, we have Umlauts. Many people have accents in their names. And people from other cultures can have most of the Unicode letters. If you don't want to exclude / discriminate these people, it will be not easy to specify the "allowed" or "forbidden" letters. |
I agree with you there, but let's also agree to:
Or do you think there could be any problems with this? |
@Ein-Tim you can also just paste letters into birth date |
In the android app, I cannot paste letters, since the format dd.mm.yy is not satisfied. |
Oh sorry, there's an input validation there for birthday, you can paste it, but it stays nil if you save the profile |
Internal Tracking ID: EXPOSUREAPP-7147 iOS |
FYI PR iOS corona-warn-app/cwa-app-ios#3018 |
FYI PR Android corona-warn-app/cwa-app-android#3597 |
I can confirm that this has been fixed with version 2.5 on iOS 14.6. Can someone under Android confirm the fix? |
@Ein-Tim well ... non-number characters can be valid in a phone number ... think of the '+' at the beginning of an international number ... and the number block on my phone has also buttons for '#' and '*' |
You're absolutely right, but I can paste letters in there... I don't know phone numbers with letter 😉 |
@ndegendogo @Ein-Tim I confirm, that on Android/Galaxy A21s emojis cannot be introduced in the RAT profile. Regarding the phone numbers: I can only use some specific characters apart from numbers, but I do not get the keyboard for the letters. This might be a specific function of this phone. Anyway, I suggest closing this issue regarding emojis as fixed. |
Yes, I also consider this as fixed. The other issue with the letters in the phone number is negligible here. Thank you @dsarkar for confirming the fix under Android. Closing as fixed. |
Thanks everybody. |
FYI: corona-warn-app/cwa-app-android#3764 from a community contributor will improve the input validation under Android even more. |
|
Avoid duplicates
Technical details
Describe the bug
You can enter emojis into the following fields:
Steps to reproduce the issue
Expected behaviour
You can only enter "normal" characters into the fields.
Possible Fix
Validate the input.
Additional context
I think that this is a priority issue since the Luca app got recently "shitstormed" for the option to enter any characters into the address field during their register process, so to prevent bad PR for this new feature I suggest to fix this ASAP.
Internal Tracking ID: EXPOSUREAPP-7147 iOS
Internal Tracking ID: EXPOSUREAPP-8108 Android
The text was updated successfully, but these errors were encountered: