Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Rapid Test Profile: Date of birth can be in the future #631

Closed
3 tasks done
FlightMS opened this issue May 12, 2021 · 13 comments
Closed
3 tasks done

Rapid Test Profile: Date of birth can be in the future #631

FlightMS opened this issue May 12, 2021 · 13 comments
Assignees
Labels
bug Something isn't working Fix 2.7 Fix is planned for 2.7 mirrored-to-jira This item is also tracked internally in JIRA

Comments

@FlightMS
Copy link

FlightMS commented May 12, 2021

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
  • Bug is not already reported in another issue

Technical details

  • Device name: iPhone 11
  • iOS version: iOS 14.5.1
  • App version: 2.2.1

Describe the bug

The date of birth in the Rapid Test Profile can be set to be in the future.

Steps to reproduce the issue

  1. Open Rapid Test profile
  2. Edit date of birth and scroll in the future

DateOfBirth2050

Expected behaviour

The date of birth can be set only for the past. Also the minimun allowed age to use the app should be considered.

Possible Fix

Additional context


Internal Tracking ID: EXPOSUREAPP-7224 Android & iOS
Internal Tracking ID: EXPOSUREAPP-7293

@dsarkar
Copy link
Member

dsarkar commented May 12, 2021

@FlightMS Thanks for the report. Internal Tracking ID: EXPOSUREAPP-7224. Best wishes, DS


Corona-Warn-App Open Source Team

@Ein-Tim
Copy link
Contributor

Ein-Tim commented May 12, 2021

Related issue: #605

There is no input validation at all. Seems like that's also the case under Android. Please check.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented May 30, 2021

Is it also possible to set the time to the future under Android? If yes this should be moved to the documentation repository.

EDIT: @fynngodau could you check this, please?

@fynngodau
Copy link

@Ein-Tim A date picker is shown on Android as well, though it doesn't use spinners like on iOS, but rather a calendar-like view. I can enter a birth date in the future without problems.

Specifically due to the layout on Android, it could happen that a user swipes to the month they are born in without realizing that they are looking at the year 2021. This is not super likely to happen, but still, maybe only dates that are more than 1 year ago should be allowed to be entered. It is highly likely that no person under the age of 1 is using the app, and since there can only be 1 RAT profile at the same time, such a change might be rather beneficial overall.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jun 7, 2021

Okay, thank you for the confirmation @fynngodau!

@dsarkar Since this affects Android too, please transfer it to the documentation repository.

@dsarkar dsarkar transferred this issue from corona-warn-app/cwa-app-ios Jun 8, 2021
@dsarkar dsarkar added bug Something isn't working mirrored-to-jira This item is also tracked internally in JIRA labels Jun 8, 2021
@marcauberer
Copy link
Member

This was fixed for Android in this pr. On iOS it might still be possible to set dob to the future though ...

@heinezen heinezen added the Fix 2.7 Fix is planned for 2.7 label Jul 29, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Aug 16, 2021

I can confirm that this has been fixed under iOS. It's no longer possible to select any date of birth in the future.

Here's a screen recording:

Date.of.birth.in.the.future.mov

Attempting to scroll to a date, month or year in the future fails.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Aug 16, 2021

@marcauberer

I would suggest to wait for feedback from somebody using Android, just to make sure that the implementation there works (as expected) too. 🙂

@marcauberer
Copy link
Member

@Ein-Tim the internal ticket is already confirmed.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Aug 16, 2021

Okay, then I leave it to you @marcauberer to close this (-:

@marcauberer
Copy link
Member

Will close it as soon as v2.7 is out ...

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Aug 21, 2021

@marcauberer
2.7 was released on August 16, 2021 See https://www.coronawarn.app/en/blog/2021-08-16-cwa-version-2-7/

I can confirm in CWA Android 2.7.1 that it is no longer possible to select a date of birth for a date in the future.

Based also on the #631 (comment) from @Ein-Tim, it should be possible to close this issue. @FlightMS might also like to double-check.

@FlightMS
Copy link
Author

I can also confirm, that it‘s not possible to set a birth date in future anymore.

Thanks to all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Fix 2.7 Fix is planned for 2.7 mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

No branches or pull requests

8 participants