Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

"Kontakt-Tagebuch": Deleting a person is deleting all contacts w that person #674

Open
dideldei opened this issue Jul 30, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@dideldei
Copy link

Avoid duplicates

  • [+] Bug is not mentioned in the FAQ
  • [unknown] Bug affects both Android and iOS, for specific issues / questions that apply only to one operating system, please raise them in the respective repositories:
  • [+] Bug is not already reported in another issue

Technical details

  • Device name: iPhone12mini
  • iOS/Android version: 14.7
  • App version: 2.5.1 (1)

Describe the bug

Maybe it is not a bug in programmers' thinking, but it definitly is a bug in regards of data integrity and community protection. When deleting a person in "Kontakt-Tagebuch" (e.g. because you will not meet the person in the nearer future) it delets all the contacts you had in the past with that person. So data about these contacts will not be sent to local health authoritis in case of an infection and you choose to share the data.

Steps to reproduce the issue

  1. Go to "Tagebuch"
  2. Add a person
  3. Add contacts w that person
  4. Delete person.
  5. All contacts (w that person) are gone.

Expected behaviour

A contact w person should no disappear when deleting the person, at least not before the end of incubation time since the last contact to that person.

Possible Fix

Depending on the current implementation: deleting a person should not be immediate, but it should be "invisible" or greyed out as a person and contacts should still be visible and in the database for 14d.
Or: Person and Contact should be more "independent" objects form each other. "Contact" should be able to store all necessary data that is valueable to inform local authorities about risky contacts.

@dideldei dideldei added the bug Something isn't working label Jul 30, 2021
@dideldei dideldei changed the title "Kontakt-Tagebuch": Deleteing a person is deleting all contacts w that person "Kontakt-Tagebuch": Deleting a person is deleting all contacts w that person Jul 30, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 30, 2021

@dideldei

I'm sure this is the intended behavior. The pop-up you see before finally deleting a person also says that this will delete all entries of this person from the contact journal.

So I would not consider this as a bug but as a feature request and therefore suggest to open an issue in the wishlist repository.

@dideldei
Copy link
Author

Thank you for your answer and suggestion.
This might be intended behavior because it is easy to implement, but it still is a bug, because it makes the user responsible for a clean data basis in a way only computers can keep a databbase clean. Implicitly it says: When you want to delete a person you have to count the days from your last contact up to 14 days and then remember to delete the person. Poor object design should not cause that kind of app behaviour.

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jul 30, 2021

@dideldei

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jul 30, 2021

Also related: corona-warn-app/cwa-wishlist#322

@vaubaehn
Copy link

A possible "fix" or an enhancement for this issue here could also be, to change the default behaviour:
By default only the person is deleted, not the contacts. A pop-up dialog could ask "Wollen Sie diese Person wirklich aus der Personen-Liste entfernen?" and offer an additional check-box "auch alle Begegnungen aus dem Tagebuch entfernen".

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 18, 2022

The Open-Source-Team should decide how to proceed with this issue. As of now, it just lays around without any process for over half a year. Mirroring it to JIRA would definitely make sense, I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants