Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ - update 'where_to_get' entry #1082

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Conversation

heinezen
Copy link
Member

Changelog:

  • Link to store pages

@@ -492,7 +492,7 @@
"anchor": "where_to_get",
"active": true,
"textblock": [
"Since the app is available, you can download it from the Apple App Store or Google Play Store."
"Since the app is available, you can download it from the <a href='https://apps.apple.com/de/app/corona-warn-app/id1512595757' target='_blank' rel='noopener noreferrer'>Apple App Store</a> or <a href='https://play.google.com/store/apps/details?id=de.rki.coronawarnapp' target='_blank' rel='noopener noreferrer'>Google Play Store</a>."
Copy link
Contributor

@MikeMcC399 MikeMcC399 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence seems a little historic. Perhaps change from:

"Since the app is available, you can download it from ..."

to:

"You can download the app from ..."

If you want to link specifically to the English language entries, the links are:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the wording

For the language, it's probably better if the website identifies the users' language via User Agent. Because I think we have a turkish language store version.

@@ -493,7 +493,7 @@
"anchor": "where_to_get",
"active": true,
"textblock": [
"Seit die App zur Verfügung steht, können Sie sie im App Store von Apple bzw. im Google Play Store herunterladen."
"Seit die App zur Verfügung steht, können Sie sie im <a href='https://apps.apple.com/de/app/corona-warn-app/id1512595757' target='_blank' rel='noopener noreferrer'>Apple App Store</a> bzw. im <a href='https://play.google.com/store/apps/details?id=de.rki.coronawarnapp' target='_blank' rel='noopener noreferrer'>Google Play Store</a> herunterladen."
Copy link
Contributor

@MikeMcC399 MikeMcC399 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly suggestion from:

"Seit die App zur Verfügung steht, können Sie sie ..."

to:

"Sie können sie ..."

And for the German language entries:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed wording (+ see above for explanation about links)

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion for updating the wording which came from around the time when the app had just been released.

Also I provided the links to the language-specific entries in the stores, in case you would like to point to those. The stores probably otherwise display in the default language of the browser. (I didn't check.)

@dsarkar
Copy link
Member

dsarkar commented Apr 16, 2021

image

image

@heinezen @MikeMcC399 Thanks! LGTM

@dsarkar dsarkar merged commit c77cd08 into master Apr 16, 2021
@dsarkar dsarkar deleted the heinezen-refaq-where_to_get branch April 16, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants