Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ - update 'where_to_get' entry #1082

Merged
merged 3 commits into from
Apr 16, 2021
Merged

FAQ - update 'where_to_get' entry #1082

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb45cc0
faq: update 'where_to_get' entry
heinezen Apr 13, 2021
4983b9e
faq: present tense
heinezen Apr 15, 2021
1b75d1f
Merge branch 'master' into heinezen-refaq-where_to_get
dsarkar Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data/faq.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@
"anchor": "where_to_get",
"active": true,
"textblock": [
"Since the app is available, you can download it from the Apple App Store or Google Play Store."
"Since the app is available, you can download it from the <a href='https://apps.apple.com/de/app/corona-warn-app/id1512595757' target='_blank' rel='noopener noreferrer'>Apple App Store</a> or <a href='https://play.google.com/store/apps/details?id=de.rki.coronawarnapp' target='_blank' rel='noopener noreferrer'>Google Play Store</a>."
Copy link
Contributor

@MikeMcC399 MikeMcC399 Apr 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence seems a little historic. Perhaps change from:

"Since the app is available, you can download it from ..."

to:

"You can download the app from ..."

If you want to link specifically to the English language entries, the links are:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the wording

For the language, it's probably better if the website identifies the users' language via User Agent. Because I think we have a turkish language store version.

]
}
]
Expand Down
2 changes: 1 addition & 1 deletion src/data/faq_de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@
"anchor": "where_to_get",
"active": true,
"textblock": [
"Seit die App zur Verfügung steht, können Sie sie im App Store von Apple bzw. im Google Play Store herunterladen."
"Seit die App zur Verfügung steht, können Sie sie im <a href='https://apps.apple.com/de/app/corona-warn-app/id1512595757' target='_blank' rel='noopener noreferrer'>Apple App Store</a> bzw. im <a href='https://play.google.com/store/apps/details?id=de.rki.coronawarnapp' target='_blank' rel='noopener noreferrer'>Google Play Store</a> herunterladen."
Copy link
Contributor

@MikeMcC399 MikeMcC399 Apr 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly suggestion from:

"Seit die App zur Verfügung steht, können Sie sie ..."

to:

"Sie können sie ..."

And for the German language entries:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed wording (+ see above for explanation about links)

]
}
]
Expand Down