Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ - redirect 'battery_optimization_background' to 'no_risk_update' #1085

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Apr 13, 2021

Changelog:

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This article assumes that enabling the prioritized background activity directly disables battery optimization. This is however not true for current app versions. In fact the function just puts the user into the Android settings level of the operating system and leaves disabling to the user.

See https://www.coronawarn.app/en/faq/#no_risk_update for instructions about how to do it.

Also corona-warn-app/cwa-app-android#1606 for an issue of the user interface usability.

@heinezen
Copy link
Member Author

@MikeMcC399 Ah yes, thank you for reminding me. This issue again... I don't think there is a quick solution for this PR right now because I do not want to link to https://www.coronawarn.app/en/faq/#no_risk_update before it has been reworked. Maybe we'll split the instructions from the https://www.coronawarn.app/en/faq/#no_risk_update entry into a new FAQ entry and then link it.

@larswmh larswmh requested a review from a team June 1, 2022 12:34
@larswmh larswmh changed the title FAQ - update 'battery_optimization_default' entry FAQ - update 'battery_optimization_background' entry Jun 1, 2022
@MikeMcC399
Copy link
Contributor

@larswmh

My comment (#1085 (review)) from one year ago is still relevant.

The Android app no longer changes the status itself. It puts the user into device settings where they make the change themselves.

Maybe it would be better just to remove this article and redirect it to #no_risk_update?

@larswmh larswmh changed the title FAQ - update 'battery_optimization_background' entry FAQ - redirect 'battery_optimization_background' to 'no_risk_update' Jun 1, 2022
@larswmh
Copy link
Member

larswmh commented Jun 1, 2022

@MikeMcC399

Maybe it would be better just to remove this article and redirect it to #no_risk_update?

Changes have been applied in 1ed9d00, thanks for the suggestion. Waiting for current build problems to be resolved and then merging this into master.

@larswmh larswmh mentioned this pull request Jun 1, 2022
5 tasks
@larswmh larswmh merged commit 91d81ae into master Jun 7, 2022
@larswmh larswmh deleted the heinezen-refaq-battery-opt branch June 7, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants