Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faq 39508 #789

Closed
wants to merge 3 commits into from
Closed

Update faq 39508 #789

wants to merge 3 commits into from

Conversation

dsarkar
Copy link
Member

@dsarkar dsarkar commented Jan 16, 2021

Closes #781

@dsarkar dsarkar self-assigned this Jan 16, 2021
@dsarkar dsarkar marked this pull request as draft January 16, 2021 11:52
@dsarkar
Copy link
Member Author

dsarkar commented Jan 16, 2021

EN

image

@dsarkar
Copy link
Member Author

dsarkar commented Jan 16, 2021

DE version in progress ...

@dsarkar dsarkar requested review from heinezen, loki-cui and mtb77 and removed request for SebastianWolf-SAP January 16, 2021 11:56
@MikeMcC399
Copy link
Contributor

@dsarkar

DE version in progress ...

The error message in German is:

"Limit bereits erreicht"

"Heute sind keine weiteren Risiko-Überprüfungen möglich, weil das von Ihrem Betriebssystem festgelegte Limit von Risiko-Überprüfungen pro Tag bereits erreicht ist. Bitte überprüfen Sie Ihren Risikostatus morgen wieder."

from strings

errors_risk_detection_limit_reached_title
errors_risk_detection_limit_reached_description

@heinezen
Copy link
Member

@dsarkar @MikeMcC399 Should this get its own FAQ entry? I don't see why the "limit reached" error necessarily has to be group together with a seemingly unelated issue.

@MikeMcC399
Copy link
Contributor

@heinezen

The underlying Android error status is still 39508. The message from CWA is however no longer 39508, it has been changed to a reader-friendlier message which says:

"Limit already reached"

Here is the link to the Google documentation for the error code:
https://developers.google.com/android/reference/com/google/android/gms/nearby/exposurenotification/ExposureNotificationStatusCodes?hl=en#public-static-final-int-failed_rate_limited.

@heinezen
Copy link
Member

I think from a user-perspective, the ammendment of 39508 is confusing (even though it makes technical sense).

I have made a counter-proposal to this approach 491faf6 where the limit reached error has a separate entry that is linked in the original 39508 entry. Didn't change much else.

@MikeMcC399
Copy link
Contributor

@heinezen
That's a valid point and a good suggestion!

@dsarkar
Copy link
Member Author

dsarkar commented Feb 11, 2021

@heinezen @MikeMcC399
491faf6 LGTM.
Usually we keep the history and track of changes of all entries. Suggestion: We move the old 39508 entry to the bottom of the FAQ, section "resolved" with a comment/link to your new article. Altogether this will look cleaner. I will discuss this internally if it is ok to proceed this way, and then, if approved, we can create finally a PR as you suggested. Thanks!

@dsarkar
Copy link
Member Author

dsarkar commented Feb 12, 2021

@heinezen @MikeMcC399
Internally discussed:
In order to harmonize, shorten, clean-up the FAQ page we now create a .md file, where we document outdated FAQ entries. We will link the old and new articles mutually, so it is transparent but at the same time, it should look cleaner.

@MikeMcC399
Copy link
Contributor

@dsarkar

In order to harmonize, shorten, clean-up the FAQ page we now create a .md file, where we document outdated FAQ entries. We will link the old and new articles mutually, so it is transparent but at the same time, it should look cleaner.

Good idea! The FAQ list is now very long and if someone is viewing on a mobile device it can be quite difficult to find the relevant information.

If the minimum versions of the app on iOS and Android are increased then the entries which only refer to problems with versions which are subject to forced update can be archived. So in the .md file split into a section for resolved issues and another section for resolved issues with versions no longer supported perhaps?

See your comments about minimum versions:
#852 (comment)
#852 (comment)

and server config:
https://github.com/corona-warn-app/cwa-server/blob/a22242bea548dea6f6e35c4fe4c8eba3d8b4fc64/services/distribution/src/main/resources/application.yaml#L112-L119

app-versions:
  latest-ios: ${IOS_LATEST_VERSION:1.5.3}
  min-ios: ${IOS_MIN_VERSION:1.5.3}
  latest-android: ${ANDROID_LATEST_VERSION:1.5.1}
  min-android: ${ANDROID_MIN_VERSION:1.5.1}
  # With ENF v2 Android apps are versioned by Version Code and not by Semantic Versioning
  min-android-version-code: ${ANDROID_MIN_VERSION_CODE:48}
  latest-android-version-code: ${ANDROID_LATEST_VERSION_CODE:48}

@dsarkar
Copy link
Member Author

dsarkar commented May 3, 2021

replaced in favour of #895

@dsarkar dsarkar closed this May 3, 2021
@dsarkar dsarkar deleted the dsarkar-faq-39508 branch May 3, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ: [Google/Android]: Error when communicating with Google API (39508) - update needed?
3 participants