Fix the PROFILE option with old CMake versions #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jschwe
commented
Aug 5, 2023
•
jschwe
commented
- Fix the PROFILE option for the legacy Generator
- Additionally test old CMake versions with the newest stable Rust version in CI (which catches the issue)
jschwe
force-pushed
the
legacy_stable
branch
2 times, most recently
from
d99b7e1 to
8b67277
Compare
jschwe
changed the title
The PROFILE option is set via the properties and does not need to be passed through anymore. That this issue has not been reported yet indicates, that there are not too many users with older CMake versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.