Allow more connection reuse for DynamoDB and S3 calls #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
dynamodb-reuse-connections
branch
from
419bdf3 to
87c4689
Compare
gouthamve
approved these changes
Mar 13, 2020
We will connect many times in parallel to the same DynamoDB server, and with default settings Go will close and re-open connections; see golang/go#13801 Raise MaxIdleConnsPerHost to avoid this. Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
dynamodb-reuse-connections
branch
from
87c4689 to
e2b66cc
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We will connect many times in parallel to the same DynamoDB server, and with default settings Go will close and re-open connections; see golang/go#13801
Raise MaxIdleConnsPerHost to avoid this.
Checklist
CHANGELOG.mdupdated