Add an option to control Content-Disposition

[TylerRick]

It looks like there's a way to control the filename (by setting @filename), but the Content-Disposition is hard-coded to be "inline":

          controller.response.headers['Content-Disposition'] = "inline; filename=\\\"\#{@filename}\\\""

Could we add an option for controlling whether Content-Disposition is inline or attachment like prawnto has?

      def set_disposition
        inline = options[:inline] ? 'inline' : 'attachment'
        filename = options[:filename] ? "filename=\"#{options[:filename]}\"" : nil
        @controller.headers["Content-Disposition"] = [inline,filename].compact.join(';')
      end

Maybe we need an options hash?

[westonganger]

Yes this feature would be much appreciated.

Could you possibly create a PR for this? If you do this please also consider if there's a better way we could be setting the filename instead of using an controller instance variable "@filename"

[westonganger]

@TylerRick any chance to take a stab at this?

[waghanza]

@cortiz I can make a PR if you want

[westonganger]

@waghanza go for it (P.S. I am the current maintainer)

[waghanza]

ok 😜, I'm on it

[ATMartin]

@waghanza Just checking in: are you still working on this feature? I'd like to take over if not. We got burned by this after a recent upgrade.

[westonganger]

@ATMartin go for it

[waghanza]

@ATMartin not working on this anymore, glad you take over