Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require any installed prawn extensions #29

Merged
merged 9 commits into from
Jun 6, 2018
Merged

Require any installed prawn extensions #29

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5db1e81
Require other prawn extension gems for the document
CodingAnarchy Mar 29, 2018
b53eb3b
Fix typo in spelling
CodingAnarchy Jun 5, 2018
be17283
Address comments on requiring additional prawn extensions
CodingAnarchy Jun 5, 2018
522e25c
Merge branch 'require-prawn-extensions' of github.com:CodingAnarchy/p…
CodingAnarchy Jun 5, 2018
3d50134
Prevent circular loading of prawn-rails
CodingAnarchy Jun 5, 2018
fe19ebd
Gem.loaded_specs returns only the list of gem names
CodingAnarchy Jun 5, 2018
a0e21d6
Don't need to get the names here
CodingAnarchy Jun 5, 2018
3fe437b
loaded_specs returns hash with string keys
CodingAnarchy Jun 5, 2018
074d536
Rescue LoadError and output error
CodingAnarchy Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/prawn-rails/document.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
require 'prawn'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-add this require prawn and remove require prawn from the loop.

require 'prawn/table'
require "prawn-rails/extension"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-add require "prawn-rails/extension" after this loop and remove from inside the loop

Gem::Specification.find_all{|s| s.name =~ /prawn/}.map(&:name).each do |gem_name|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the condition for find_all should probably bes.name.start_with?('prawn-')

case gem_name
when 'prawn-rails' then require 'prawn-rails/extension'
else require gem_name.gsub('-', '/')
end
end

module PrawnRails

Expand Down