Support custom 'Content-Disposition' options #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATMartin
commented
Aug 7, 2019
lib/prawn-rails/rails_helper.rb
Outdated
| options = get_prawn_options | ||
|
|
||
| # Don't override the 'Content-Disposition' if we've chosen to set it elsewhere. | ||
| controller.response.headers['Content-Disposition'] ||= "#{options[:disposition]}; filename=\"#{options[:filename]}\"" |
There was a problem hiding this comment.
This ||= was the biggest pain point we had - we set our own Content-Dispositions in our controllers, and having the gem totally scrap those was frustrating!
ATMartin
commented
Aug 7, 2019
westonganger
reviewed
Aug 7, 2019
ATMartin
force-pushed
the
custom-content-disposition
branch
from
ab76ecb
to
03b4847
Compare
|
@westonganger I've updated this to be |
westonganger
reviewed
Aug 7, 2019
README.md
Outdated
| end | ||
| ``` | ||
|
|
||
| This uses the [`Content-Disposition` HTTP header](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#As_a_response_header_for_the_main_body). If you've already set this header, `prawn-rails` will *not* override it. |
There was a problem hiding this comment.
Could you maybe show an example usage/assignment of this header?
|
Thanks! Could you also update the changelog? |
…prawn-rails into custom-content-disposition
|
@westonganger Updated. I bumped to 1.3.x since this could break someone using the old renderer with |
|
Merged! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33 by allowing much more detailed control of the
Content-Dispositionheader generated byprawn-rails:@filenameivar (preserves current functionality).@filenameset, use the:filenameand:dispositionoption keys on theprawn_documenthelper.Content-Disposition=inline;)Also: updated tests & README.