Update Fee tables #399
Merged
Update Fee tables #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
force-pushed
the
396-fee-table
branch
from
c0a4d97 to
a913974
Compare
willclarktech
force-pushed
the
396-fee-table
branch
2 times, most recently
from
ba7b7c8 to
9abaa6e
Compare
| */ | ||
| export interface FeeTable { | ||
| export interface CosmWasmFeeTable extends FeeTable { |
There was a problem hiding this comment.
If we use extend here (assuming the CosmWasmClient can do everything the CosmosClient can), then we can remove the send field here, right?
There was a problem hiding this comment.
Yes. Do you think we have any need for the completely generic FeeTable (e.g. to support clients which turn off some Cosmos SDK functionality)?
There was a problem hiding this comment.
No, this is good for now.
I wanted to have CosmWasmClient extending CosmosClient but that does not work because there is no multi inheritance in JS and we need inheritance for SigningCosmWasmClient and SigningCosmosClient.
There was a problem hiding this comment.
OK, well we have FeeTable anyway. 😄
willclarktech
force-pushed
the
396-fee-table
branch
from
e47486c to
8089c16
Compare
willclarktech
force-pushed
the
396-fee-table
branch
2 times, most recently
from
b387b44 to
a737df0
Compare
willclarktech
force-pushed
the
396-fee-table
branch
from
a737df0 to
47018d2
Compare
This was referenced Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396
Opening this draft PR now to get feedback on the design. Still to do:
DecimalclassSigningCosmWasmClient