Skip to content

Commit

Permalink
feat: allow full control on rocksdb db opening
Browse files Browse the repository at this point in the history
  • Loading branch information
yihuang committed Apr 8, 2024
1 parent fab0ae0 commit 02d503a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## UNRELEASED

* Allow full control in rocksdb opening

## [v1.0.2] - 2024-02-26

* Downgrade Go version in go.mod to 1.19
Expand Down
4 changes: 2 additions & 2 deletions prefixdb_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ package db

import (
"bytes"
"crypto/rand"
"encoding/binary"
"fmt"
"math/rand"
"path/filepath"
"sync"
"testing"
Expand Down Expand Up @@ -32,7 +32,7 @@ func taskKey(i, k int) []byte {

func randomValue() []byte {
b := make([]byte, 16)
rand.Read(b) //nolint:staticcheck,gosec
rand.Read(b)

Check failure on line 35 in prefixdb_test.go

View workflow job for this annotation

GitHub Actions / golangci

Error return value of `rand.Read` is not checked (errcheck)
return b
}

Expand Down
12 changes: 11 additions & 1 deletion rocksdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,17 @@ func NewRocksDBWithOptions(name string, dir string, opts *grocksdb.Options) (*Ro
wo := grocksdb.NewDefaultWriteOptions()
woSync := grocksdb.NewDefaultWriteOptions()
woSync.SetSync(true)
return NewRocksDBWithRaw(db, ro, wo, woSync), nil
return NewRocksDBWithRawDB(db, ro, wo, woSync), nil
}

// NewRocksDBWithRawDB lets caller has full control on how the db instance is constructed
func NewRocksDBWithRawDB(
db *grocksdb.DB,
ro *grocksdb.ReadOptions,
wo *grocksdb.WriteOptions,
woSync *grocksdb.WriteOptions,
) *RocksDB {
return NewRocksDBWithRaw(db, ro, wo, woSync)
}

// NewRocksDBWithRaw is useful if user want to create the db in read-only or seconday-standby mode,
Expand Down

0 comments on commit 02d503a

Please sign in to comment.