From 2c4b397acf9806a2bc12d72764ade274013d855d Mon Sep 17 00:00:00 2001 From: Julian Toledano Date: Mon, 4 Mar 2024 11:26:20 +0100 Subject: [PATCH] CHANGELOG & UPGRADING --- CHANGELOG.md | 1 + UPGRADING.md | 9 ++++++--- x/auth/CHANGELOG.md | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e9939c7bd8d..c23c2c1e985b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -94,6 +94,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i ### API Breaking Changes +* (types) [#19447](https://github.com/cosmos/cosmos-sdk/pull/19447) `module.testutil.MakeTestEncodingConfig` now takes `CodecOptions` as argument. * (types) [#19512](https://github.com/cosmos/cosmos-sdk/pull/19512) Remove basic manager and all related functions (`module.BasicManager`, `module.NewBasicManager`, `module.NewBasicManagerFromManager`, `NewGenesisOnlyAppModule`). * The module manager now can do everything that the basic manager was doing. * When using runtime, just inject the module manager when needed using your app config. diff --git a/UPGRADING.md b/UPGRADING.md index 8ed75edacba2..46efd2176644 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -12,16 +12,19 @@ In this section we describe the changes made in Cosmos SDK' SimApp. #### Client (`root.go`) -The `client` package has been refactored to make use of the address codecs (address, validator address, consensus address, etc.). +The `client` package has been refactored to make use of the address codecs (address, validator address, consensus address, etc.) +and address bech32 prefixes (address and validator address). This is part of the work of abstracting the SDK from the global bech32 config. -This means the address codecs must be provided in the `client.Context` in the application client (usually `root.go`). +This means the address codecs and prefixes must be provided in the `client.Context` in the application client (usually `root.go`). ```diff clientCtx = clientCtx. + WithAddressCodec(addressCodec). + WithValidatorAddressCodec(validatorAddressCodec). -+ WithConsensusAddressCodec(consensusAddressCodec) ++ WithConsensusAddressCodec(consensusAddressCodec). ++ WithAddressPrefix("cosmos"). ++ WithValidatorPrefix("cosmosvaloper") ``` **When using `depinject` / `app v2`, the client codecs can be provided directly from application config.** diff --git a/x/auth/CHANGELOG.md b/x/auth/CHANGELOG.md index 33c4017bf38e..585075a9d39e 100644 --- a/x/auth/CHANGELOG.md +++ b/x/auth/CHANGELOG.md @@ -43,6 +43,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### API Breaking Changes +* [#19447](https://github.com/cosmos/cosmos-sdk/pull/19447) Address and validator address codecs are now arguments of `NewTxConfig`. `NewDefaultSigningOptions` has been replaced with `NewSigningOptions` which takes address and validator address codecs as arguments. * [#17985](https://github.com/cosmos/cosmos-sdk/pull/17985) Remove `StdTxConfig` * [#19161](https://github.com/cosmos/cosmos-sdk/pull/19161) Remove `simulate` from `SetGasMeter` * [#19363](https://github.com/cosmos/cosmos-sdk/pull/19363) Remove `IterateAccounts` and `GetAllAccounts` methods from the AccountKeeper interface and Keeper.