From 5456e54d6517b1fbe83cf285dba4da409d74ce7a Mon Sep 17 00:00:00 2001 From: Matthew Slipper Date: Thu, 16 Aug 2018 00:31:18 -0700 Subject: [PATCH] Remove --select in block command Closes #1968. --- PENDING.md | 1 + client/rpc/block.go | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/PENDING.md b/PENDING.md index 7f297c0f372..159d4fa96c4 100644 --- a/PENDING.md +++ b/PENDING.md @@ -41,6 +41,7 @@ IMPROVEMENTS * [x/stake] \#2000 Added tests for new staking endpoints * Gaia CLI (`gaiacli`) + * [cli] #2060 removed `--select` from `block` command * Gaia * [x/stake] [#2023](https://github.com/cosmos/cosmos-sdk/pull/2023) Terminate iteration loop in `UpdateBondedValidators` and `UpdateBondedValidatorsFull` when the first revoked validator is encountered and perform a sanity check. diff --git a/client/rpc/block.go b/client/rpc/block.go index fb4376bc1ad..d16f383424f 100644 --- a/client/rpc/block.go +++ b/client/rpc/block.go @@ -12,10 +12,6 @@ import ( "github.com/spf13/cobra" ) -const ( - flagSelect = "select" -) - //BlockCommand returns the verified block data for a given heights func BlockCommand() *cobra.Command { cmd := &cobra.Command{ @@ -27,7 +23,6 @@ func BlockCommand() *cobra.Command { cmd.Flags().StringP(client.FlagNode, "n", "tcp://localhost:26657", "Node to connect to") // TODO: change this to false when we can cmd.Flags().Bool(client.FlagTrustNode, true, "Don't verify proofs for responses") - cmd.Flags().StringSlice(flagSelect, []string{"header", "tx"}, "Fields to return (header|txs|results)") return cmd } @@ -38,7 +33,6 @@ func getBlock(cliCtx context.CLIContext, height *int64) ([]byte, error) { return nil, err } - // TODO: actually honor the --select flag! // header -> BlockchainInfo // header, tx -> Block // results -> BlockResults