Skip to content

Commit

Permalink
Merge pull request #1862 from cosmos/dev/speed_up_handleMsgEditValidator
Browse files Browse the repository at this point in the history
x/stake: Speed up handleMsgEditValidator
  • Loading branch information
rigelrozanski authored Jul 30, 2018
2 parents 89dd333 + 0bb3497 commit c40d5de
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ IMPROVEMENTS
* [tests] Fixes ansible scripts to work with AWS too
* [tests] \#1806 CLI tests are now behind the build flag 'cli_test', so go test works on a new repo
* [x/gov] Initial governance parameters can now be set in the genesis file
* [x/stake] \#1815 Sped up the processing of `EditValidator` txs.

BUG FIXES
* \#1666 Add intra-tx counter to the genesis validators
Expand Down
4 changes: 3 additions & 1 deletion x/stake/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,9 @@ func handleMsgEditValidator(ctx sdk.Context, msg types.MsgEditValidator, k keepe
}
validator.Description = description

k.UpdateValidator(ctx, validator)
// We don't need to run through all the power update logic within k.UpdateValidator
// We just need to override the entry in state, since only the description has changed.
k.SetValidator(ctx, validator)
tags := sdk.NewTags(
tags.Action, tags.ActionEditValidator,
tags.DstValidator, []byte(msg.ValidatorAddr.String()),
Expand Down
4 changes: 2 additions & 2 deletions x/stake/keeper/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ func (k Keeper) ClearTendermintUpdates(ctx sdk.Context) {

//___________________________________________________________________________

// Perfom all the nessisary steps for when a validator changes its power. This
// Perfom all the necessary steps for when a validator changes its power. This
// function updates all validator stores as well as tendermint update store.
// It may kick out validators if new validator is entering the bonded validator
// It may kick out validators if a new validator is entering the bonded validator
// group.
//
// nolint: gocyclo
Expand Down

0 comments on commit c40d5de

Please sign in to comment.