Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate x/authz to use app wiring #12084

Closed
6 of 7 tasks
Tracked by #11899
atheeshp opened this issue May 30, 2022 · 1 comment · Fixed by #12279
Closed
6 of 7 tasks
Tracked by #11899

migrate x/authz to use app wiring #12084

atheeshp opened this issue May 30, 2022 · 1 comment · Fixed by #12279
Assignees

Comments

@atheeshp
Copy link
Contributor

atheeshp commented May 30, 2022

  • add app wiring functions in module.go
  • add app.yml for integration tests
  • decouple from simapp

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@atheeshp atheeshp self-assigned this May 30, 2022
@atheeshp atheeshp moved this to 📝 Todo in Cosmos-SDK May 30, 2022
@atheeshp atheeshp moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 2, 2022
@atheeshp atheeshp moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Jun 7, 2022
@tac0turtle tac0turtle moved this from 👀 Needs Review to 💪 In Progress in Cosmos-SDK Jun 8, 2022
mergify bot pushed a commit that referenced this issue Jun 8, 2022
## Description

ref: #12084, #11899



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@likhita-809 likhita-809 moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jun 9, 2022
@likhita-809 likhita-809 moved this from 👏 Done to 💪 In Progress in Cosmos-SDK Jun 9, 2022
Repository owner moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jun 20, 2022
@julienrbrt julienrbrt reopened this Jun 20, 2022
Repository owner moved this from 👏 Done to 📝 Todo in Cosmos-SDK Jun 20, 2022
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 20, 2022
@tac0turtle
Copy link
Member

closing as completed

Repository owner moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jun 30, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
## Description

ref: cosmos#12084, cosmos#11899



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants