Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helper functions for adding accounts to genesis state. #12091

Closed
4 tasks
Tracked by #13085
ValarDragon opened this issue May 31, 2022 · 0 comments · Fixed by #13298
Closed
4 tasks
Tracked by #13085

Make helper functions for adding accounts to genesis state. #12091

ValarDragon opened this issue May 31, 2022 · 0 comments · Fixed by #13298
Assignees
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@ValarDragon
Copy link
Contributor

Summary

Right now, its quite intensive to add a new Account with a given balance to the genesis state. (e.g. the map[string]json.RawMessage representation)

In Osmosis. this (logically) simple operation is a 40 line endeavour: https://github.com/osmosis-labs/osmosis/blob/main/tests/e2e/chain/config.go#L95-L134

Proposal

Make a helper function(s) in either Auth, Bank, or both, to significantly ease the complexity of adding a new account to an existing appGenesisState. There are numerous occassions that I think this will come in handy, outside of Osmosis' e2e testing. (e.g. airdrop / genesis file building frameworks)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@julienrbrt julienrbrt self-assigned this Jun 10, 2022
@julienrbrt julienrbrt moved this to 📝 Todo in Cosmos-SDK Jun 10, 2022
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 10, 2022
@julienrbrt julienrbrt moved this from 💪 In Progress to 📝 Todo in Cosmos-SDK Jun 17, 2022
@julienrbrt julienrbrt removed their assignment Jun 24, 2022
@julienrbrt julienrbrt self-assigned this Aug 20, 2022
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Sep 9, 2022
@julienrbrt julienrbrt moved this from 💪 In Progress to 📝 Todo in Cosmos-SDK Sep 9, 2022
@julienrbrt julienrbrt added the T: Dev UX UX for SDK developers (i.e. how to call our code) label Sep 9, 2022
@julienrbrt julienrbrt mentioned this issue Sep 9, 2022
18 tasks
@likhita-809 likhita-809 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Sep 15, 2022
@likhita-809 likhita-809 moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Sep 21, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
Archived in project
4 participants