Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linux systems that don't keep stty in /bin #12289

Closed
4 tasks
cameronfyfe opened this issue Jun 16, 2022 · 2 comments · Fixed by #14633
Closed
4 tasks

Support linux systems that don't keep stty in /bin #12289

cameronfyfe opened this issue Jun 16, 2022 · 2 comments · Fixed by #14633

Comments

@cameronfyfe
Copy link

Summary

System calls to stty to enable/disable terminal echos rely on a hardcoded path at /bin/stty.

This is due to hardcoded path strings in https://github.com/bgentry/speakeasy/tree/v0.1.0.

There is currently an issue and PR that should fix the issue once merged. I bumped the issue today.

Problem Definition

This prevents binaries using this library from being operable on systems that don't have stty located in /bin, unless the user moves stty or symlinks /bin/stty to point to the location on their system.

Proposal

  • What
    • Use the system's search path to find stty instead of relying on hardcoded /bin/stty.
  • How

This would expand out-of-the box support for cosmos-sdk onto more system environments. In my specific case, this would allow me to run cosmos-sdk based binaries on NixOS systems.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

It seems like the easiest approach is to just wait for that PR to be merged and released. Dependabot will automatically open a PR for the SDK to bump the version.

@julienrbrt
Copy link
Member

For what it's worth, I have approved the PR there (ping @bgentry)
Closing this as when it gets implemented dependabot will alert us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants