Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABCI Query Proof Verification Missing? #12740

Closed
alexanderbez opened this issue Jul 27, 2022 · 3 comments
Closed

ABCI Query Proof Verification Missing? #12740

alexanderbez opened this issue Jul 27, 2022 · 3 comments
Labels
T:Bug

Comments

@alexanderbez
Copy link
Contributor

Summary of Bug

When querying for k/v state via ABCI, we seem to be missing proof verification in Context#queryABCI. You can see this in v0.46 here. In fact, this makes the if branch completely irrelevant!

I looked back at previous versions and this seems to be missing for many of them. Last version I can find proof verification at is v0.39 here.

Was this done on purpose @aaronc?

Version

main and all versions > v0.39.x
@amaury1093
Copy link
Contributor

amaury1093 commented Jul 28, 2022 •
edited
Loading

This is relevant: #6805 (comment)

@alexanderbez
Copy link
Contributor Author

Ahh right, it's coming back to me. Thanks for the link. I think we can close this then once we remove that redundant if statement.

@tac0turtle
Copy link
Member

closing in favour of #7036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amaury1093 @alexanderbez @tac0turtle