Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Emit depositor in proposal_deposit event #19849

Closed
dadamu opened this issue Mar 25, 2024 · 2 comments · Fixed by #19853
Closed

[Feature]: Emit depositor in proposal_deposit event #19849

dadamu opened this issue Mar 25, 2024 · 2 comments · Fixed by #19853
Assignees
@devbull25
Labels
good first issue T:feature-request

Comments

@dadamu
Copy link
Contributor

dadamu commented Mar 25, 2024

Summary

Emit depositor in proposal_deposit event

Problem Definition

No response

Proposed Feature

It allows users to track proposal deposit transactions or blocks by event proposal_deposit.depositor= "<depositor-address>", and it also allows applications get depositor from transaction event without parsing message or authz message with codec.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Mar 25, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Mar 25, 2024 •
edited
Loading

Let's watch out to not inadvertently end up with the whole proposal in an event 😅.
Now we have the proposer, msgs, ID, so I think we should only add depositor as suggested here and proposal type and stop there. :D

@devbull25
Copy link
Contributor

hi, can i work on this issue?

@devbull25 devbull25 mentioned this issue Mar 25, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Mar 25, 2024
@mergify mergify bot mentioned this issue Mar 25, 2024
Merged
12 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devbull25 devbull25

Labels
good first issue T:feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(x/gov): emit depositor in proposal_deposit event devbull25/cosmos-sdk
3 participants
@dadamu @julienrbrt @devbull25