Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Cleanup followup from #5711 #5761

Closed
4 tasks
AdityaSripal opened this issue Mar 7, 2020 · 1 comment
Closed
4 tasks

Test Cleanup followup from #5711 #5761

AdityaSripal opened this issue Mar 7, 2020 · 1 comment
Assignees
@AdityaSripal
Labels
T: Tests
Milestone
IBC 1.0 [Implemen...

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Mar 7, 2020 •
edited
Loading

Followup from #5711:

  • Need to rewrite some of the failure test cases in 03-connection and 04-channel so that they fail for the stated reason in the test-case name
  • Enforce consistency on connectionID naming through testsuites in 03-connection and 04-channel. Connection IDs are consistent within tests, but not across the entire test-suite which is important for understandability
  • Write tests for TimeoutOnClose and CleanupPacket for ORDERED and UNORDERED channels
  • De-duplify test setup code (mainly TestChain and queryProof) in 03-connection and 04-channel and move to separate test-utils package
@cwgoes cwgoes added this to the IBC Implementation milestone Mar 17, 2020
@fedekunze
Copy link
Collaborator

moved to #5558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
T: Tests
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

No branches or pull requests
3 participants
@AdityaSripal @cwgoes @fedekunze