Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad (0.39) Migration #6828

Closed
4 tasks
alexanderbez opened this issue Jul 23, 2020 · 0 comments · Fixed by #6829
Closed
4 tasks

Launchpad (0.39) Migration #6828

alexanderbez opened this issue Jul 23, 2020 · 0 comments · Fixed by #6829

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Jul 23, 2020

In Launchpad 0.39 we last-minute introduced, and rightfully so, a change to BaseAccount where we removed the custom JSON marshaling because Bech32 doesn't play nicely with multisig addresses.

We need to update 0.39 migration:

func Migrate(authGenState v038auth.GenesisState) v038auth.GenesisState {
	for _, account := range authGenState.Accounts {
		// set coins to nil and allow the JSON encoding to omit coins
		if err := account.SetCoins(nil); err != nil {
			panic(fmt.Sprintf("failed to set account coins to nil: %s", err))
		}
	}

	authGenState.Accounts = v038auth.SanitizeGenesisAccounts(authGenState.Accounts)
	return authGenState
}

The migration here is meant to be 0.40 and so should be bumped.

/cc @alessio @jgimeno


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant