You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Signatures are heavily used blockchain workload, so if possible it's good to avoid unnecessary conversion operations
Problem Definition
In #7268 we introduce back ed25519 in SDK. The first implementation makes conversion to x/crypto/ed25519 each time we call any signature related function. This is suboptimal.
We can experiment with type alias or embed stdlib crypto/ed25519 PubKey and PrivateKey. This approach will remove type conversions and unnecessary memory allocations, but we will still need to keep method wrappers.
gogoproto.casttype can be used to instrument protobuf compiler.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Signatures are heavily used blockchain workload, so if possible it's good to avoid unnecessary conversion operations
Problem Definition
In #7268 we introduce back ed25519 in SDK. The first implementation makes conversion to
x/crypto/ed25519
each time we call any signature related function. This is suboptimal.Ref: https://github.com/cosmos/cosmos-sdk/pull/7268/files#r493581731
Proposal
We can experiment with type alias or embed stdlib crypto/ed25519 PubKey and PrivateKey. This approach will remove type conversions and unnecessary memory allocations, but we will still need to keep method wrappers.
gogoproto.casttype
can be used to instrument protobuf compiler.For Admin Use
The text was updated successfully, but these errors were encountered: