-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usages of protoc-gen-swagger to protoc-gen-openapiv2 #7620
Comments
@anilcse Any reason why we shouldn't update this? The latest version with |
No strong reasons, we can update. We need to investigate the changes before updating this may be. I can spend some time on this. |
Hi, Any updates on this? I found that The issue is that google.protobuf.Any:
type: object
properties:
type_url:
type: string
value:
type: string
format: byte
description: >-
Must be a valid serialized protocol buffer of the above specified
type. The expected structure is like the structure generated by google.protobuf.Any:
type: object
properties:
'@type':
type: string
additionalProperties: {} |
we want to upgrade, but haven't had the capacity to do so, we will look into it |
@tac0turtle I updated it to fulfill my needs. If you feels it is okay, I can submit a PR: dadamu@9cea181 |
Summary
GRPC Gateway has renamed the
protoc-gen-swagger
package toprotoc-gen-openapiv2
(see here). We need to update thego get
references in./contrib/devtools/proto-tools-installer.sh
here. There are possibly other places where this rename has caused issues, so we should investigate what else may broken by this.Note: This was originally reported as a bug, but in actuality, when running
make proto-tools
go-get will find the old version ofgrpc-gateway
that has theprotoc-gen-swagger
subdirectory.Despite this not actually breaking anything currently, I think it would be a good idea for us to update to use
protoc-gen-openapiv2
, as this will get built from the current version ofgrpc-gateway
, which does not happen for theprotoc-gen-swagger
binary.Steps to Reproduce
make proto-tools
For Admin Use
The text was updated successfully, but these errors were encountered: