Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add simapp setup helpers #10020

Merged
merged 14 commits into from
Sep 15, 2021
Merged

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 27, 2021

Description

ref: #8961

Following up on #9697, this PR is the second step for #8961.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #10020 (a066318) into master (ae9834e) will increase coverage by 0.11%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10020      +/-   ##
==========================================
+ Coverage   63.63%   63.74%   +0.11%     
==========================================
  Files         573      573              
  Lines       53610    53655      +45     
==========================================
+ Hits        34114    34203      +89     
+ Misses      17549    17505      -44     
  Partials     1947     1947              
Impacted Files Coverage Δ
simapp/test_helpers.go 26.72% <80.00%> (+26.03%) ⬆️
simapp/app.go 81.58% <0.00%> (+0.63%) ⬆️

@orijbot
Copy link

orijbot commented Aug 27, 2021

@aleem1314 aleem1314 changed the title feat(tests): add functions to setup custom simapp feat(tests): add simapp setup helpers Aug 27, 2021
@aleem1314 aleem1314 marked this pull request as ready for review August 27, 2021 15:01
simapp/app_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simapp/test_helpers.go Show resolved Hide resolved
testutil/mock/privval.go Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

Note, you should be adding t.Helper() calls to any function that takes a *testing.T as an argument.

@alexanderbez alexanderbez merged commit 22cd778 into master Sep 15, 2021
@alexanderbez alexanderbez deleted the aleem/8961-simapp-setup branch September 15, 2021 21:18
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants