fix: revert \#10169 (amino multisig key unmarshalling) #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc and
alexanderbez
as code owners
|
Visit https://dashboard.github.orijtech.com?back=0&pr=10193&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
tomtau
added a commit
to crypto-org-chain/cosmos-sdk
that referenced
this pull request
Sep 21, 2021
…10193) * Revert "fix: unmarshalling issue with multisig keys in master (backport cosmos#10061) (cosmos#10169)" This reverts commit fcaff72. * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
evan-forbes
pushed a commit
to evan-forbes/cosmos-sdk
that referenced
this pull request
Oct 12, 2021
…10193) * Revert "fix: unmarshalling issue with multisig keys in master (backport cosmos#10061) (cosmos#10169)" This reverts commit fcaff72. * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
evan-forbes
pushed a commit
to evan-forbes/cosmos-sdk
that referenced
this pull request
Nov 1, 2021
…10193) * Revert "fix: unmarshalling issue with multisig keys in master (backport cosmos#10061) (cosmos#10169)" This reverts commit fcaff72. * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…10193) * Revert "fix: unmarshalling issue with multisig keys in master (backport cosmos#10061) (cosmos#10169)" This reverts commit fcaff72. * Update CHANGELOG.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverting #10169 because we are not sure if this correctly solves the issue and we don't want to block v0.44.1 release.