feat: start app wiring with runtime and x/params modules #11924

aaronc · 2022-05-10T17:46:07Z

Description

This PR initializes app wiring in the most basic way I could think of (more basic than #11900).

It adds:

a new runtime module which allows for a hybrid app config/old app.go setup
module registration for the x/params module
a hybrid integration with simapp where:
- runtime does some of the stuff app.go used to do (begin and end blockers),
- app.go still does init chain and registers services (for now)
- the x/params keeper is injected by the container

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…iring-init

aaronc · 2022-05-10T21:04:11Z

Looks like the graphviz dep in container breaks the arm build which sounds like a deal breaker. I should probably replace it with something lighter weight like https://github.com/emicklei/dot. Will open an issue

…iring-init

aaronc · 2022-05-16T15:00:05Z

go.mod

@@ -151,6 +159,8 @@ require (
 )

 replace (
+	cosmossdk.io/api => ./api


After this PR we can tag and remove this

How often should we tag a new version then? (as this has not yet been done)

As often as we need to, but with alpha tags only for now

faddat · 2022-05-18T23:30:12Z

<3

runtime/app.go

runtime/module.go

…iring-init

aaronc · 2022-05-24T17:00:28Z

We need to refactor this because of the reversion of middleware. I think I will need to tackle x/auth in this PR as well because we need a TxDecoder. Is that okay?

aaronc · 2022-05-24T17:04:32Z

runtime/builder.go

+	for _, option := range a.app.baseAppOptions {
+		baseAppOptions = append(baseAppOptions, option)
+	}
+	bApp := baseapp.NewBaseApp(a.app.config.AppName, logger, db, baseAppOptions...)


The NewBaseApp constructor now requires a TxDecoder param. Before it was using a TxHandler setter so I didn't need to do this in the constructor.

There are two options:

do x/auth in this PR as well which will provide the TxEncoder

create a SetTxEncoder setter on BaseApp and allow this to be nil in the constructor

Thoughts

I'm in favor of constructor injection wherever possible, so therefore expanding the scope of this PR to include the x/auth changes seems OK to me.

But we don't want auth to be required in order for app wiring to work. Therefore I think I'll add the SetTxEncoder method

…iring-init

aaronc · 2022-05-24T19:16:43Z

This has been updated. Would appreciate at least one more look from someone before merging

kocubinski · 2022-05-24T19:44:14Z

x/params/module.go

+	return k, runtime.WrapAppModule(m), baseappOpt
+}
+
+func provideSubSpace(key container.ModuleKey, k keeper.Keeper) types.Subspace {


I don't see this output being used anywhere... are there future plans for it or have I missed something?

In pretty much every follow up PR it will be used

kocubinski · 2022-05-24T22:00:57Z

👀 Trying to understand the context for the test failures-

FAIL	github.com/cosmos/cosmos-sdk/x/upgrade/client/testutil	0.019s
?   	github.com/cosmos/cosmos-sdk/x/upgrade/exported	[no test files]
panic: proto: file "cosmos/app/v1alpha1/config.proto" is already registered
	previously from: "github.com/cosmos/cosmos-sdk/api/cosmos/app/v1alpha1"
	currently from:  "cosmossdk.io/api/cosmos/app/v1alpha1"
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

- go mod tidy

kocubinski

LGTM.

2 CI failures which seem OK:

../../../../pkg/mod/golang.org/x/exp@v0.0.0-20220428152302-39d4317da171/constraints/constraints.go:41:2: syntax error: unexpected ~, expecting method or interface name
../../../../pkg/mod/golang.org/x/exp@v0.0.0-20220428152302-39d4317da171/constraints/constraints.go:49:10: syntax error: unexpected |, expecting semicolon or newline or }
note: module requires Go 1.18

gobencher seems not compatible with go 1.18.

and in the liveness-test (make localnet-start)

Step 8/20 : RUN go mod download
 ---> Running in cdba6f9ada8f
go: cosmossdk.io/api@v0.1.0-alpha8 (replaced by ./api): reading api/go.mod: open /work/api/go.mod: no such file or directory

I think will be resolved when a release of core is made and the replace directives in ./go.mod can be removed.

amaury1093

✅ late approval. Seems like different pieces are finally getting together.

amaury1093 · 2022-05-25T11:32:30Z

simapp/app.go

-func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino, key, tkey storetypes.StoreKey) paramskeeper.Keeper {
-	paramsKeeper := paramskeeper.NewKeeper(appCodec, legacyAmino, key, tkey)
-
+func initParamsKeeper(paramsKeeper paramskeeper.Keeper) {


out of curiosity: How would this function look in the final app-wired simapp?

it would be gone

amaury1093 · 2022-05-25T11:39:08Z

simapp/app.go


 	// NOTE: The genutils module must occur after staking so that pools are
 	// properly initialized with tokens from genesis accounts.
 	// NOTE: The genutils module must also occur after auth so that it can access the params from auth.
 	// NOTE: Capability module must occur first so that it can initialize any capabilities
 	// so that other modules that want to create or claim capabilities afterwards in InitChain
 	// can do so safely.
-	app.mm.SetOrderInitGenesis(
+	app.ModuleManager.SetOrderInitGenesis(


Any reason you kept this here, instead of putting it into the runtime module config?

because there is some custom stuff happening with x/upgrade and module versions. once we get to x/upgrade i think we can switch this

amaury1093 · 2022-05-25T11:50:36Z

runtime/app.go

+// RegisterTxService implements the Application.RegisterTxService method.
+func (a *App) RegisterTxService(clientCtx client.Context) {
+	authtx.RegisterTxService(a.GRPCQueryRouter(), clientCtx, a.Simulate, a.interfaceRegistry)
+}
+
+// RegisterTendermintService implements the Application.RegisterTendermintService method.
+func (a *App) RegisterTendermintService(clientCtx client.Context) {


these 2 seem weird in the runtime. Can they be modules?

yes, they should be. at least they shouldn't be standalone methods on server.Application. maybe runtime should register the tendermint service, but authtx should either go in auth or we should have a standalone tx or auth/tx module. should we add an issue as part of the epic to fix this?

## Description This was causing sim failures like: ``` exporting genesis... 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=0/12 module=x/crisis name=gov/module-account 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=1/12 module=x/crisis name=bank/nonnegative-outstanding 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=2/12 module=x/crisis name=bank/total-supply 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=3/12 module=x/crisis name=group/Group-TotalWeight 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=4/12 module=x/crisis name=distribution/nonnegative-outstanding 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=5/12 module=x/crisis name=distribution/can-withdraw 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=6/12 module=x/crisis name=distribution/reference-count 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=7/12 module=x/crisis name=distribution/module-account 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=8/12 module=x/crisis name=staking/module-accounts 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=9/12 module=x/crisis name=staking/nonnegative-power 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=10/12 module=x/crisis name=staking/positive-delegation 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=11/12 module=x/crisis name=staking/delegator-shares 2022-05-25T10:36:39-05:00 INFO asserted all invariants duration=1194.381198 height=50 module=x/crisis importing genesis... --- FAIL: TestAppSimulationAfterImport (20.98s) panic: validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction ({824635701280}) [recovered] panic: validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction ({824635701280}) goroutine 76 [running]: testing.tRunner.func1.2({0x1b88020, 0xc0035d70b0}) /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1389 +0x24e testing.tRunner.func1() /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1392 +0x39f panic({0x1b88020, 0xc0035d70b0}) /home/mkoco/sdk/go1.18.2/src/runtime/panic.go:838 +0x207 github.com/cosmos/cosmos-sdk/types/module.(*Manager).InitGenesis(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/types/module/module.go:329 +0x4fd github.com/cosmos/cosmos-sdk/runtime.(*App).InitChainer(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/runtime/app.go:121 +0x12e github.com/cosmos/cosmos-sdk/simapp.(*SimApp).InitChainer(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/simapp/app.go:504 +0x178 github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).InitChain(0xc000fb1340, {{0x0, 0x0, 0x0}, {0x0, 0x0}, 0x0, {0x0, 0x0, 0x0}, ...}) /home/mkoco/dev/regen/cosmos-sdk/baseapp/abci.go:69 +0x3f5 github.com/cosmos/cosmos-sdk/simapp.TestAppSimulationAfterImport(0xc000abf520) /home/mkoco/dev/regen/cosmos-sdk/simapp/sim_test.go:269 +0xd67 testing.tRunner(0xc000abf520, 0x2590ac0) /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1439 +0x102 created by testing.(*T).Run /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1486 +0x35f FAIL github.com/cosmos/cosmos-sdk/simapp 21.018s FAIL ``` ### Root cause Prior to merge of #11924, SimApp calls [module/NewManager](https://github.com/cosmos/cosmos-sdk/blob/2b549b807c13f66dca68965206163ca400d0dbe0/simapp/app.go#L344), which implicitly sets sane default values of [OrderExportGenesis](https://github.com/cosmos/cosmos-sdk/blob/2b549b807c13f66dca68965206163ca400d0dbe0/types/module/module.go#L239) from the modules passed as parameters. Since this usage was deprecated in favor of [RegisterModules](https://github.com/cosmos/cosmos-sdk/blob/823d2a7f28f10a360b543748a6e90e01bb5d3c23/simapp/app.go#L354) in the app wiring work, `OrderExportGenesis` was now `nil`, resulting in empty `genesisData` in [ExportGenesis](https://github.com/cosmos/cosmos-sdk/blob/823d2a7f28f10a360b543748a6e90e01bb5d3c23/types/module/module.go#L339) ### Fix Explicitly set `OrderExportGenesis` with same module order as `OrderInitGenesis` from `SimApp`. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

* feat: start app wiring with runtime and x/params modules * WIP * WIP * docs * docs, cleanup * fixing tests * rollback unrelated changes * fix * test fixes * simplification, tests * fix tests * docs * go mod tidy * update module path * codegen * address middleware removal * update container alpha 4 * Fix cosmossdk.io/api dependency conflict - go mod tidy Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>

## Description This was causing sim failures like: ``` exporting genesis... 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=0/12 module=x/crisis name=gov/module-account 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=1/12 module=x/crisis name=bank/nonnegative-outstanding 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=2/12 module=x/crisis name=bank/total-supply 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=3/12 module=x/crisis name=group/Group-TotalWeight 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=4/12 module=x/crisis name=distribution/nonnegative-outstanding 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=5/12 module=x/crisis name=distribution/can-withdraw 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=6/12 module=x/crisis name=distribution/reference-count 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=7/12 module=x/crisis name=distribution/module-account 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=8/12 module=x/crisis name=staking/module-accounts 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=9/12 module=x/crisis name=staking/nonnegative-power 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=10/12 module=x/crisis name=staking/positive-delegation 2022-05-25T10:36:38-05:00 INFO asserting crisis invariants inv=11/12 module=x/crisis name=staking/delegator-shares 2022-05-25T10:36:39-05:00 INFO asserted all invariants duration=1194.381198 height=50 module=x/crisis importing genesis... --- FAIL: TestAppSimulationAfterImport (20.98s) panic: validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction ({824635701280}) [recovered] panic: validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction ({824635701280}) goroutine 76 [running]: testing.tRunner.func1.2({0x1b88020, 0xc0035d70b0}) /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1389 +0x24e testing.tRunner.func1() /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1392 +0x39f panic({0x1b88020, 0xc0035d70b0}) /home/mkoco/sdk/go1.18.2/src/runtime/panic.go:838 +0x207 github.com/cosmos/cosmos-sdk/types/module.(*Manager).InitGenesis(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/types/module/module.go:329 +0x4fd github.com/cosmos/cosmos-sdk/runtime.(*App).InitChainer(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/runtime/app.go:121 +0x12e github.com/cosmos/cosmos-sdk/simapp.(*SimApp).InitChainer(_, {{0x28b5990, 0xc0001b2000}, {0x28c2da0, 0xc002494600}, {{0x0, 0x0}, {0x0, 0x0}, 0x0, ...}, ...}, ...) /home/mkoco/dev/regen/cosmos-sdk/simapp/app.go:504 +0x178 github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).InitChain(0xc000fb1340, {{0x0, 0x0, 0x0}, {0x0, 0x0}, 0x0, {0x0, 0x0, 0x0}, ...}) /home/mkoco/dev/regen/cosmos-sdk/baseapp/abci.go:69 +0x3f5 github.com/cosmos/cosmos-sdk/simapp.TestAppSimulationAfterImport(0xc000abf520) /home/mkoco/dev/regen/cosmos-sdk/simapp/sim_test.go:269 +0xd67 testing.tRunner(0xc000abf520, 0x2590ac0) /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1439 +0x102 created by testing.(*T).Run /home/mkoco/sdk/go1.18.2/src/testing/testing.go:1486 +0x35f FAIL github.com/cosmos/cosmos-sdk/simapp 21.018s FAIL ``` ### Root cause Prior to merge of cosmos#11924, SimApp calls [module/NewManager](https://github.com/cosmos/cosmos-sdk/blob/2b549b807c13f66dca68965206163ca400d0dbe0/simapp/app.go#L344), which implicitly sets sane default values of [OrderExportGenesis](https://github.com/cosmos/cosmos-sdk/blob/2b549b807c13f66dca68965206163ca400d0dbe0/types/module/module.go#L239) from the modules passed as parameters. Since this usage was deprecated in favor of [RegisterModules](https://github.com/cosmos/cosmos-sdk/blob/823d2a7f28f10a360b543748a6e90e01bb5d3c23/simapp/app.go#L354) in the app wiring work, `OrderExportGenesis` was now `nil`, resulting in empty `genesisData` in [ExportGenesis](https://github.com/cosmos/cosmos-sdk/blob/823d2a7f28f10a360b543748a6e90e01bb5d3c23/types/module/module.go#L339) ### Fix Explicitly set `OrderExportGenesis` with same module order as `OrderInitGenesis` from `SimApp`. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

aaronc added 3 commits May 10, 2022 13:06

feat: start app wiring with runtime and x/params modules

1abe96f

Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/app-w…

35ad13d

…iring-init

WIP

d03c7cb

github-actions bot added C:x/auth C:x/bank C:x/feegrant C:x/params C:x/staking labels May 10, 2022

aaronc mentioned this pull request May 10, 2022

EPIC: Separate all SDK modules into standalone go modules #11899

Closed

81 tasks

aaronc added 6 commits May 10, 2022 14:04

WIP

78e455b

docs

38896cf

docs, cleanup

5bb0256

Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/app-w…

69b1d5f

…iring-init

fixing tests

d7ff0b0

rollback unrelated changes

d9beb5c

github-actions bot removed C:x/auth C:x/feegrant C:x/bank C:x/staking labels May 10, 2022

fix

137d76e

test fixes

e08a858

aaronc mentioned this pull request May 11, 2022

refactor(container)!: remove dependency on C graphviz #11934

Merged

19 tasks

aaronc and others added 5 commits May 11, 2022 13:30

Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/app-w…

ef84d47

…iring-init

simplification, tests

39c01a5

Merge branch 'main' into aaronc/app-wiring-init

5b0c58f

fix tests

1b94c8f

docs

725d7b9

aaronc marked this pull request as ready for review May 11, 2022 17:53

aaronc requested a review from a team as a code owner May 11, 2022 17:53

aaronc commented May 16, 2022

View reviewed changes

kocubinski reviewed May 22, 2022

View reviewed changes

runtime/app.go Show resolved Hide resolved

amaury1093 requested a review from JeancarloBarrios May 23, 2022 16:01

aaronc mentioned this pull request May 23, 2022

feat(x/auth): app wiring setup #12019

Merged

19 tasks

kocubinski reviewed May 23, 2022

View reviewed changes

runtime/module.go Outdated Show resolved Hide resolved

tac0turtle approved these changes May 23, 2022

View reviewed changes

facundomedica mentioned this pull request May 24, 2022

migrate x/params to use app wiring #12023

Closed

3 tasks

Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/app-w…

7b93995

…iring-init

aaronc commented May 24, 2022

View reviewed changes

kocubinski mentioned this pull request May 24, 2022

feat(x/bank): app wiring migration #12032

Merged

19 tasks

aaronc added 3 commits May 24, 2022 15:12

address middleware removal

c06dcd6

update container alpha 4

f5dba8b

Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/app-w…

28b94e2

…iring-init

kocubinski reviewed May 24, 2022

View reviewed changes

aaronc requested review from kocubinski and alexanderbez May 24, 2022 21:46

Fix cosmossdk.io/api dependency conflict

e9f8191

- go mod tidy

kocubinski approved these changes May 25, 2022

View reviewed changes

aaronc merged commit 1f9871c into main May 25, 2022

aaronc deleted the aaronc/app-wiring-init branch May 25, 2022 01:09

amaury1093 reviewed May 25, 2022

View reviewed changes

kocubinski mentioned this pull request May 25, 2022

fix: call SetOrderExportGenesis from SimApp #12048

Merged

19 tasks

kocubinski mentioned this pull request May 26, 2022

fix: app wiring simulation failures #12051

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: start app wiring with runtime and x/params modules #11924

feat: start app wiring with runtime and x/params modules #11924

aaronc commented May 10, 2022 •

edited

Loading

aaronc commented May 10, 2022

aaronc May 16, 2022

julienrbrt Jun 6, 2022 •

edited

Loading

aaronc Jun 6, 2022

faddat commented May 18, 2022

aaronc commented May 24, 2022

aaronc May 24, 2022

kocubinski May 24, 2022

aaronc May 24, 2022

aaronc commented May 24, 2022

kocubinski May 24, 2022

aaronc May 24, 2022

kocubinski commented May 24, 2022

kocubinski left a comment

amaury1093 left a comment

amaury1093 May 25, 2022

aaronc May 25, 2022

amaury1093 May 25, 2022

aaronc May 25, 2022

amaury1093 May 25, 2022

aaronc May 25, 2022

feat: start app wiring with runtime and x/params modules #11924

feat: start app wiring with runtime and x/params modules #11924

Conversation

aaronc commented May 10, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

aaronc commented May 10, 2022

Choose a reason for hiding this comment

julienrbrt Jun 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

faddat commented May 18, 2022

aaronc commented May 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aaronc commented May 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kocubinski commented May 24, 2022

kocubinski left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aaronc commented May 10, 2022 •

edited

Loading

julienrbrt Jun 6, 2022 •

edited

Loading