From 5b0c5d8e607eba22818e8282a1f895f445397ad7 Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Wed, 10 Aug 2022 22:54:30 +0700 Subject: [PATCH 1/4] update make format --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 2c57fc741a23..32c6d2fb4893 100644 --- a/Makefile +++ b/Makefile @@ -357,9 +357,9 @@ lint-fix: .PHONY: lint lint-fix format: - find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name '*.pb.go' | xargs gofmt -w -s - find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name '*.pb.go' | xargs misspell -w - find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name '*.pb.go' | xargs goimports -w -local github.com/cosmos/cosmos-sdk + find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs misspell -w + find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs gofumpt -w -l + golangci-lint run --fix .PHONY: format ############################################################################### From 1150efc70fe7ecb4c08cf2d838d7806d4c328389 Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Wed, 10 Aug 2022 22:56:14 +0700 Subject: [PATCH 2/4] Update Makefile --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index 32c6d2fb4893..254db596022d 100644 --- a/Makefile +++ b/Makefile @@ -357,7 +357,6 @@ lint-fix: .PHONY: lint lint-fix format: - find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs misspell -w find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs gofumpt -w -l golangci-lint run --fix .PHONY: format From 21b2a10059082b2712457ceea93167637e8d2a0d Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Wed, 10 Aug 2022 22:58:20 +0700 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 24fdc6e3a828..38dcebbd6844 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Improvements +* [#12892](https://github.com/cosmos/cosmos-sdk/pull/12892) `make format` now runs only gofumpt and golangci-lint run ./... --fix, replacing `goimports` `gofmt` and `misspell` * [#12846](https://github.com/cosmos/cosmos-sdk/pull/12846) Remove `RandomizedParams` from the `AppModuleSimulation` interface which is no longer needed. * (events) [#12850](https://github.com/cosmos/cosmos-sdk/pull/12850) Add a new `fee_payer` attribute to the `tx` event that is emitted from the `DeductFeeDecorator` AnteHandler decorator. * (ci) [#12854](https://github.com/cosmos/cosmos-sdk/pull/12854) Use ghcr.io to host the proto builder image. Update proto builder image to go 1.19 From b5e1279a2ea6cd36c8114e4591df5fcd9b6f9895 Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Wed, 10 Aug 2022 22:59:52 +0700 Subject: [PATCH 4/4] Update .golangci.yml --- .golangci.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 173d530b9b32..0fd62ef0a3dd 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -12,8 +12,7 @@ linters: - exportloopref - goconst - gocritic - - gofmt - - goimports + - gofumpt - gosec - gosimple - govet @@ -32,12 +31,6 @@ issues: - text: "Use of weak random number generator" linters: - gosec - - text: "comment on exported var" - linters: - - golint - - text: "don't use an underscore in package name" - linters: - - golint - text: "ST1003:" linters: - stylecheck