chore: lint tests

.golangci.yml

@@ -1,7 +1,10 @@
 run:
-  tests: false
+  tests: true
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 5m
+  sort-results: true
+  allow-parallel-runners: true
+  exclude-dir: testutil/testdata_pulsar
 
 linters:
   disable-all: true
@@ -20,6 +23,7 @@ linters:
     - nakedret
     - nolintlint
     - staticcheck
+    - revive
     - stylecheck
     - typecheck
     - unconvert
@@ -42,6 +46,9 @@ issues:
       text: "SA1019:"
       linters:
         - staticcheck
+    - text: "leading space"
+      linters:
+        - nolintlint
 
   max-issues-per-linter: 10000
   max-same-issues: 10000

baseapp/block_gas_test.go

@@ -214,7 +214,7 @@ func createTestTx(txConfig client.TxConfig, txBuilder client.TxBuilder, privs []
 			Sequence:      accSeqs[i],
 		}
 		sigV2, err := tx.SignWithPrivKey(
-			nil, txConfig.SignModeHandler().DefaultMode(), signerData,
+			nil, txConfig.SignModeHandler().DefaultMode(), signerData, //nolint:staticcheck
 			txBuilder, priv, txConfig, accSeqs[i])
 		if err != nil {
 			return nil, nil, err

baseapp/msg_service_router_test.go

@@ -131,7 +131,7 @@ func TestMsgService(t *testing.T) {
 		Sequence:      0,
 	}
 	sigV2, err = tx.SignWithPrivKey(
-		nil, txConfig.SignModeHandler().DefaultMode(), signerData,
+		nil, txConfig.SignModeHandler().DefaultMode(), signerData, //nolint:staticcheck // SA1019: txConfig.SignModeHandler().DefaultMode() is deprecated: use txConfig.SignModeHandler().DefaultMode() instead.
 		txBuilder, priv, txConfig, 0)
 	require.NoError(t, err)
 	err = txBuilder.SetSignatures(sigV2)

baseapp/utils_test.go

@@ -30,9 +30,7 @@ import (
 	"github.com/cosmos/cosmos-sdk/x/auth/signing"
 )
 
-var (
-	ParamStoreKey = []byte("paramstore")
-)
+var ParamStoreKey = []byte("paramstore")
 
 func defaultLogger() log.Logger {
 	if testing.Verbose() {

client/config/config_test.go

@@ -26,7 +26,7 @@ const (
 // initClientContext initiates client Context for tests
 func initClientContext(t *testing.T, envVar string) (client.Context, func()) {
 	home := t.TempDir()
-	chainId := "test-chain"
+	chainId := "test-chain" //nolint:revive
 	clientCtx := client.Context{}.
 		WithHomeDir(home).
 		WithViper("").
@@ -58,7 +58,7 @@ func TestConfigCmd(t *testing.T) {
 	_, err := clitestutil.ExecTestCLICmd(clientCtx, cmd, args)
 	require.NoError(t, err)
 
-	//./build/simd config node //http://localhost:1
+	// ./build/simd config node //http://localhost:1
 	b := bytes.NewBufferString("")
 	cmd.SetOut(b)
 	cmd.SetArgs([]string{"node"})

client/context_test.go

@@ -46,7 +46,7 @@ func TestContext_PrintProto(t *testing.T) {
 	// json
 	buf := &bytes.Buffer{}
 	ctx = ctx.WithOutput(buf)
-	ctx.OutputFormat = "json"
+	ctx.OutputFormat = "json" //nolint:goconst
 	err = ctx.PrintProto(hasAnimal)
 	require.NoError(t, err)
 	require.Equal(t,
@@ -56,7 +56,7 @@ func TestContext_PrintProto(t *testing.T) {
 	// yaml
 	buf = &bytes.Buffer{}
 	ctx = ctx.WithOutput(buf)
-	ctx.OutputFormat = "text"
+	ctx.OutputFormat = "text" //nolint:goconst
 	err = ctx.PrintProto(hasAnimal)
 	require.NoError(t, err)
 	require.Equal(t,

client/grpc_query_test.go

@@ -26,7 +26,6 @@ import (
 	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
 	bankkeeper "github.com/cosmos/cosmos-sdk/x/bank/keeper"
 	"github.com/cosmos/cosmos-sdk/x/bank/types"
-	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
 )
 
 type IntegrationTestSuite struct {
@@ -65,7 +64,7 @@ func (s *IntegrationTestSuite) SetupSuite() {
 	s.genesisAccountBalance = 100000000000000
 	senderPrivKey := secp256k1.GenPrivKey()
 	acc := authtypes.NewBaseAccount(senderPrivKey.PubKey().Address().Bytes(), senderPrivKey.PubKey(), 0, 0)
-	balance := banktypes.Balance{
+	balance := types.Balance{
 		Address: acc.GetAddress().String(),
 		Coins:   sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(s.genesisAccountBalance))),
 	}
@@ -120,7 +119,7 @@ func (s *IntegrationTestSuite) TestGRPCQuery() {
 	var header metadata.MD
 	res, err := s.bankClient.Balance(
 		context.Background(),
-		&banktypes.QueryBalanceRequest{Address: s.genesisAccount.GetAddress().String(), Denom: denom},
+		&types.QueryBalanceRequest{Address: s.genesisAccount.GetAddress().String(), Denom: denom},
 		grpc.Header(&header), // Also fetch grpc header
 	)
 	s.Require().NoError(err)

client/keys/import_test.go

@@ -94,7 +94,7 @@ HbP+c6JmeJy9JXe2rbbF1QtCX1gLqGcDQPBXiCtFvP7/8wTZtVOPj8vREzhZ9ElO
 			t.Cleanup(cleanupKeys(t, kb, "keyname1"))
 
 			keyfile := filepath.Join(kbHome, "key.asc")
-			require.NoError(t, os.WriteFile(keyfile, []byte(armoredKey), 0o644))
+			require.NoError(t, os.WriteFile(keyfile, []byte(armoredKey), 0o644)) //nolint:gosec
 
 			defer func() {
 				_ = os.RemoveAll(kbHome)

client/keys/output_test.go

@@ -2,10 +2,11 @@ package keys
 
 import (
 	"fmt"
+	"testing"
+
 	"github.com/cosmos/cosmos-sdk/codec"
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
 	cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
-	"testing"
 
 	"github.com/stretchr/testify/require"
 

client/pruning/main.go

@@ -19,9 +19,9 @@ import (
 
 const FlagAppDBBackend = "app-db-backend"
 
-// PruningCmd prunes the sdk root multi store history versions based on the pruning options
+// Cmd prunes the sdk root multi store history versions based on the pruning options
 // specified by command flags.
-func PruningCmd(appCreator servertypes.AppCreator) *cobra.Command {
+func Cmd(appCreator servertypes.AppCreator) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "prune",
 		Short: "Prune app history states by keeping the recent heights and deleting old heights",

client/testutil/util.go

@@ -10,7 +10,7 @@ import (
 	"cosmossdk.io/core/appconfig"
 	"cosmossdk.io/depinject"
 	"github.com/cosmos/cosmos-sdk/codec"
-	_ "github.com/cosmos/cosmos-sdk/runtime"
+	_ "github.com/cosmos/cosmos-sdk/runtime" // Register runtime module
 )
 
 var TestConfig = appconfig.Compose(&appv1alpha1.Config{

client/tx/legacy_test.go

@@ -59,7 +59,6 @@ func buildTestTx(t *testing.T, builder client.TxBuilder) {
 
 type TestSuite struct {
 	suite.Suite
-	codec    codec.Codec
 	amino    *codec.LegacyAmino
 	protoCfg client.TxConfig
 	aminoCfg client.TxConfig

client/tx/tx_test.go

@@ -353,7 +353,7 @@ func TestSign(t *testing.T) {
 	var prevSigs []signingtypes.SignatureV2
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			err = tx.Sign(nil, tc.txf, tc.from, tc.txb, tc.overwrite)
+			err = tx.Sign(nil, tc.txf, tc.from, tc.txb, tc.overwrite) //nolint:staticcheck
 			if len(tc.expectedPKs) == 0 {
 				requireT.Error(err)
 			} else {
@@ -422,8 +422,9 @@ func TestPreprocessHook(t *testing.T) {
 	msg1 := banktypes.NewMsgSend(addr1, sdk.AccAddress("to"), nil)
 	msg2 := banktypes.NewMsgSend(addr2, sdk.AccAddress("to"), nil)
 	txb, err := txfDirect.BuildUnsignedTx(msg1, msg2)
+	requireT.NoError(err)
 
-	err = tx.Sign(nil, txfDirect, from, txb, false)
+	err = tx.Sign(nil, txfDirect, from, txb, false) //nolint:staticcheck
 	requireT.NoError(err)
 
 	// Run preprocessing

codec/any_test.go

@@ -6,16 +6,15 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/cosmos/cosmos-sdk/codec"
-	"github.com/cosmos/cosmos-sdk/codec/types"
 	codectypes "github.com/cosmos/cosmos-sdk/codec/types"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
 	cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
 	"github.com/cosmos/cosmos-sdk/testutil/testdata"
 	"github.com/cosmos/cosmos-sdk/types/module/testutil"
 )
 
-func NewTestInterfaceRegistry() types.InterfaceRegistry {
-	registry := types.NewInterfaceRegistry()
+func NewTestInterfaceRegistry() codectypes.InterfaceRegistry {
+	registry := codectypes.NewInterfaceRegistry()
 	registry.RegisterInterface("Animal", (*testdata.Animal)(nil))
 	registry.RegisterImplementations(
 		(*testdata.Animal)(nil),
@@ -26,10 +25,10 @@ func NewTestInterfaceRegistry() types.InterfaceRegistry {
 }
 
 func TestMarshalAny(t *testing.T) {
-	catRegistry := types.NewInterfaceRegistry()
+	catRegistry := codectypes.NewInterfaceRegistry()
 	catRegistry.RegisterImplementations((*testdata.Animal)(nil), &testdata.Cat{})
 
-	registry := types.NewInterfaceRegistry()
+	registry := codectypes.NewInterfaceRegistry()
 
 	cdc := codec.NewProtoCodec(registry)
 
@@ -65,7 +64,7 @@ func TestMarshalAny(t *testing.T) {
 	require.Equal(t, kitty, animal)
 
 	// nil should fail
-	registry = NewTestInterfaceRegistry()
+	_ = NewTestInterfaceRegistry()
 	err = cdc.UnmarshalInterface(catBz, nil)
 	require.Error(t, err)
 }

codec/proto_codec_test.go

@@ -92,7 +92,7 @@ func TestProtoCodecMarshal(t *testing.T) {
 	err = cdc.UnmarshalInterface(bz, &animal)
 	require.NoError(t, err)
 
-	bz, err = cdc.MarshalInterface(bird)
+	_, err = cdc.MarshalInterface(bird)
 	require.ErrorContains(t, err, "does not have a registered interface")
 
 	bz, err = cartoonCdc.MarshalInterface(bird)

codec/types/any.go

@@ -1,3 +1,4 @@
+// nolint
 package types
 
 import (

codec/types/any_internal_test.go

@@ -17,7 +17,7 @@ func (d Dog) Greet() string { return d.Name }
 func (d *Dog) Reset()                  { d.Name = "" }
 func (d *Dog) String() string          { return d.Name }
 func (d *Dog) ProtoMessage()           {}
-func (d *Dog) XXX_MessageName() string { return "tests/dog" }
+func (d *Dog) XXX_MessageName() string { return "tests/dog" } //nolint:revive
 
 type Animal interface {
 	Greet() string

codec/types/any_test.go

@@ -19,7 +19,7 @@ var _ proto.Message = (*errOnMarshal)(nil)
 
 var errAlways = fmt.Errorf("always erroring")
 
-func (eom *errOnMarshal) XXX_Marshal(b []byte, deterministic bool) ([]byte, error) {
+func (eom *errOnMarshal) XXX_Marshal(b []byte, deterministic bool) ([]byte, error) { //nolint:revive
 	return nil, errAlways
 }
 

codec/types/types_test.go

@@ -44,7 +44,7 @@ var (
 func (dog FakeDog) Reset()                  {}
 func (dog FakeDog) String() string          { return "fakedog" }
 func (dog FakeDog) ProtoMessage()           {}
-func (dog FakeDog) XXX_MessageName() string { return proto.MessageName(&testdata.Dog{}) }
+func (dog FakeDog) XXX_MessageName() string { return proto.MessageName(&testdata.Dog{}) } //nolint:revive
 func (dog FakeDog) Greet() string           { return "fakedog" }
 
 func TestRegister(t *testing.T) {

crypto/hd/fundraiser_test.go

@@ -75,7 +75,7 @@ func TestFundraiserCompatibility(t *testing.T) {
 
 		require.Equal(t, seedB, seed)
 		require.Equal(t, master[:], masterB, fmt.Sprintf("Expected masters to match for %d", i))
-		require.Equal(t, priv[:], privB, "Expected priv keys to match")
+		require.Equal(t, priv, privB, "Expected priv keys to match")
 		pubBFixed := make([]byte, secp256k1.PubKeySize)
 		copy(pubBFixed, pubB)
 		require.Equal(t, pub, &secp256k1.PubKey{Key: pubBFixed}, fmt.Sprintf("Expected pub keys to match for %d", i))

crypto/hd/hdpath_test.go

@@ -185,7 +185,7 @@ func TestDeriveHDPathRange(t *testing.T) {
 	}
 }
 
-func ExampleStringifyPathParams() {
+func ExampleStringifyPathParams() { //nolint:govet
 	path := hd.NewParams(44, 0, 0, false, 0)
 	fmt.Println(path.String())
 	path = hd.NewParams(44, 33, 7, true, 9)
@@ -195,7 +195,7 @@ func ExampleStringifyPathParams() {
 	// m/44'/33'/7'/1/9
 }
 
-func ExampleSomeBIP32TestVecs() {
+func ExampleSomeBIP32TestVecs() { //nolint:govet
 	seed := mnemonicToSeed("barrel original fuel morning among eternal " +
 		"filter ball stove pluck matrix mechanic")
 	master, ch := hd.ComputeMastersFromSeed(seed)
@@ -206,34 +206,34 @@ func ExampleSomeBIP32TestVecs() {
 	if err != nil {
 		fmt.Println("INVALID")
 	} else {
-		fmt.Println(hex.EncodeToString(priv[:]))
+		fmt.Println(hex.EncodeToString(priv))
 	}
 	// bitcoin
 	priv, err = hd.DerivePrivateKeyForPath(master, ch, "44'/0'/0'/0/0")
 	if err != nil {
 		fmt.Println("INVALID")
 	} else {
-		fmt.Println(hex.EncodeToString(priv[:]))
+		fmt.Println(hex.EncodeToString(priv))
 	}
 	// ether
 	priv, err = hd.DerivePrivateKeyForPath(master, ch, "44'/60'/0'/0/0")
 	if err != nil {
 		fmt.Println("INVALID")
 	} else {
-		fmt.Println(hex.EncodeToString(priv[:]))
+		fmt.Println(hex.EncodeToString(priv))
 	}
 	// INVALID
 	priv, err = hd.DerivePrivateKeyForPath(master, ch, "X/0'/0'/0/0")
 	if err != nil {
 		fmt.Println("INVALID")
 	} else {
-		fmt.Println(hex.EncodeToString(priv[:]))
+		fmt.Println(hex.EncodeToString(priv))
 	}
 	priv, err = hd.DerivePrivateKeyForPath(master, ch, "-44/0'/0'/0/0")
 	if err != nil {
 		fmt.Println("INVALID")
 	} else {
-		fmt.Println(hex.EncodeToString(priv[:]))
+		fmt.Println(hex.EncodeToString(priv))
 	}
 
 	fmt.Println()
@@ -245,13 +245,13 @@ func ExampleSomeBIP32TestVecs() {
 			"gorilla ranch hour rival razor call lunar mention taste vacant woman sister")
 	master, ch = hd.ComputeMastersFromSeed(seed)
 	priv, _ = hd.DerivePrivateKeyForPath(master, ch, "44'/1'/1'/0/4")
-	fmt.Println(hex.EncodeToString(priv[:]))
+	fmt.Println(hex.EncodeToString(priv))
 
 	seed = mnemonicToSeed("idea naive region square margin day captain habit " +
 		"gun second farm pact pulse someone armed")
 	master, ch = hd.ComputeMastersFromSeed(seed)
 	priv, _ = hd.DerivePrivateKeyForPath(master, ch, "44'/0'/0'/0/420")
-	fmt.Println(hex.EncodeToString(priv[:]))
+	fmt.Println(hex.EncodeToString(priv))
 
 	fmt.Println()
 	fmt.Println("BIP 32 example")
@@ -261,7 +261,7 @@ func ExampleSomeBIP32TestVecs() {
 	seed = mnemonicToSeed("monitor flock loyal sick object grunt duty ride develop assault harsh history")
 	master, ch = hd.ComputeMastersFromSeed(seed)
 	priv, _ = hd.DerivePrivateKeyForPath(master, ch, "0/7")
-	fmt.Println(hex.EncodeToString(priv[:]))
+	fmt.Println(hex.EncodeToString(priv))
 
 	// Output: keys from fundraiser test-vector (cosmos, bitcoin, ether)
 	//