ready-for-review: check new rat decimal string length #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaoxiaff
commented
Jul 4, 2018
xiaoxiaff
commented
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG.md
- Updated Gaia/Examples
- Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
- Added appropriate labels to PR (ex. wip, ready-for-review, docs)
* Add ledger instructions * Address PR comments
Codecov Report
@@ Coverage Diff @@
## develop #1534 +/- ##
===========================================
+ Coverage 64.13% 64.18% +0.04%
===========================================
Files 118 118
Lines 6489 6491 +2
===========================================
+ Hits 4162 4166 +4
+ Misses 2075 2074 -1
+ Partials 252 251 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.