update params for x/gov and default config #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test_cli failing locally for me |
cwgoes
reviewed
Jul 16, 2018
| * [gaiad] Default config updates: | ||
| - `timeout_commit=5000` so blocks only made every 5s | ||
| - `prof_listen_addr=localhost:6060` so profile server is on by default | ||
| - `p2p.send_rate` and `p2p.recv_rate` increases 10x (~5MB/s) |
There was a problem hiding this comment.
Have these changed? The before/after config values are both 5120000. Or did we miss the changelog last time?
There was a problem hiding this comment.
Changelog entry is in v0.20 but I don't think it actually took effect, so it was just using the Tendermint defaults
cwgoes
previously approved these changes
Jul 16, 2018
|
Reverting just the governance changes: diff --git a/x/gov/keeper.go b/x/gov/keeper.go
index 4569743e..992147ab 100644
--- a/x/gov/keeper.go
+++ b/x/gov/keeper.go
@@ -129,9 +129,9 @@ func (keeper Keeper) activateVotingPeriod(ctx sdk.Context, proposal Proposal) {
// Procedures
var (
- defaultMinDeposit int64 = 100
- defaultMaxDepositPeriod int64 = 10000
- defaultVotingPeriod int64 = 10000
+ defaultMinDeposit int64 = 10
+ defaultMaxDepositPeriod int64 = 200
+ defaultVotingPeriod int64 = 200
)
|
Governance CLI test fixes
Codecov Report
@@ Coverage Diff @@
## develop #1690 +/- ##
===========================================
- Coverage 62.37% 60.64% -1.73%
===========================================
Files 120 119 -1
Lines 7117 6906 -211
===========================================
- Hits 4439 4188 -251
- Misses 2427 2479 +52
+ Partials 251 239 -12 |
cwgoes
approved these changes
Jul 16, 2018
|
Tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on v0.21.1 ...