Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): Add Triple key #17024

Merged
merged 6 commits into from
Jul 17, 2023
Merged

feat(collections): Add Triple key #17024

merged 6 commits into from
Jul 17, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #17022

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review July 17, 2023 10:11
@testinginprod testinginprod requested a review from a team as a code owner July 17, 2023 10:11
@github-prbot github-prbot requested review from a team, facundomedica and samricotta and removed request for a team July 17, 2023 10:11
tac0turtle
tac0turtle approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, what are some use cases where you would want this?

@testinginprod
Copy link
Contributor Author

utACK, what are some use cases where you would want this?

Staking, feegrant have keys composed of three keys

@testinginprod testinginprod enabled auto-merge July 17, 2023 14:16
julienrbrt
julienrbrt approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@testinginprod testinginprod added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit dd585ba Jul 17, 2023
@testinginprod testinginprod deleted the tip/coll/triple branch July 17, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(collections): Triple key
3 participants
@testinginprod @tac0turtle @julienrbrt