Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove iavl-lazy-loading from config #17177

Merged
merged 2 commits into from
Jul 28, 2023
Merged

refactor: remove iavl-lazy-loading from config #17177

merged 2 commits into from
Jul 28, 2023

Conversation

julienrbrt
Copy link
Member

Description

This config was not used and seem not present from IAVL v1.0.0.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 28, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner July 28, 2023 12:26
@github-actions github-actions bot added the C:Confix Issues and PR related to Confix label Jul 28, 2023
@yihuang
Copy link
Collaborator

yihuang commented Jul 28, 2023

Yeah, irrelevant to iavl 1.0

@cool-develope
Copy link
Contributor

cool-develope commented Jul 28, 2023

thanks for this cleanup, I removed only the config from baseapp previously.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit 898f66a Jul 28, 2023
@julienrbrt julienrbrt deleted the julien/store branch July 28, 2023 13:31
mergify bot pushed a commit that referenced this pull request Jul 28, 2023
(cherry picked from commit 898f66a)

# Conflicts:
#	CHANGELOG.md
julienrbrt added a commit that referenced this pull request Jul 28, 2023
…17178)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Confix Issues and PR related to Confix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants