Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update starshp-action version #18301

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

Anmol1696
Copy link
Contributor

@Anmol1696 Anmol1696 commented Oct 30, 2023

Description

Upgrade starship-action to be compatible with go1.21.
Using the PR to test out the gh-action.

Successful Test run: https://github.com/cosmos/cosmos-sdk/actions/runs/6691158765/job/18177860438?pr=18301


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

Chores:

  • Updated the starship-action action to the latest release candidate version 0.2.19-rc0 for improved performance and stability.
  • Added a new input cli-version to ensure our workflow uses a specific version of the CLI, enhancing the reliability of our tests.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2023

Walkthrough

In this update, we've made some key changes to our GitHub workflow. The starship-action action has been updated to a release candidate version, and a new input cli-version has been added, indicating a specific commit hash.

Changes

File Summary
.github/workflows/starship-tests.yml Updated starship-action from 0.2.18 to 0.2.19-rc0. Added new input cli-version with value 8da948db87cc0ff819d81de3151eeb013b19152c.

🐇🍂

As the leaves fall and the air grows cold,

Our code takes a leap, bold and bold.

With a new version in sight, and a commit hash bright,

We hop towards the future, with all our might.

So here's to the changes, big and small,

In the spirit of autumn, we embrace them all! 🍁🎃

This poem celebrates the changes we've made, the spirit of continuous improvement, and the beauty of the autumn season.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@Anmol1696 Anmol1696 changed the title WIP: chore: update starshp-action version chore: update starshp-action version Oct 30, 2023
@Anmol1696 Anmol1696 marked this pull request as ready for review October 30, 2023 10:17
@Anmol1696 Anmol1696 requested a review from a team as a code owner October 30, 2023 10:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 661d201 and edbea60.
Files selected for processing (1)
  • .github/workflows/starship-tests.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/starship-tests.yml

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@tac0turtle tac0turtle added this pull request to the merge queue Oct 30, 2023
Merged via the queue into cosmos:main with commit 393de26 Oct 30, 2023
54 checks passed
atheeshp pushed a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants